emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Fix org-meta-return for checkbox lists
Date: Thu, 14 Jun 2018 20:41:15 +0200	[thread overview]
Message-ID: <87zhzx8b3o.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY3BiA31kAjqaBbQtQUMiTLpMDjqt+_VtvXRbjuSUreBQQ@mail.gmail.com> (Kaushal Modi's message of "Thu, 14 Jun 2018 11:30:37 -0400")

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Currently if you do M-RET in a checkbox list item, the next item does not
> become a checkbox automatically. This patch fixes that.
>
> I have been using this fix locally for few months. But never got to
> submitting it as I need to yet write a test for it.
>
> Does that patch look good (apart from missing tests). Should I format it
> w.r.t to next? or master?

IMO, there is nothing to fix. Inserting a checkbox in every item is not
mandatory.

Furthermore, currently, M-RET inserts a regular item and M-S-RET inserts
it with a checkbox. With your patch, both M-RET and M-S-RET do the same
thing, which is sub-optimal.

My vote is to keep the current behaviour.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2018-06-14 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 15:30 Fix org-meta-return for checkbox lists Kaushal Modi
2018-06-14 18:41 ` Nicolas Goaziou [this message]
2018-06-15 13:53   ` Bernt Hansen
2018-06-15 14:01     ` Kaushal Modi
2018-06-15 14:10       ` Nicolas Goaziou
2018-06-15 14:19         ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhzx8b3o.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).