From: Jack Kamm <jackkamm@gmail.com>
To: Christian Vanderwall <christian@cvdub.net>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-python.el: Fix issue with sessions on remote machines
Date: Tue, 18 Aug 2020 07:21:53 -0700 [thread overview]
Message-ID: <87zh6syqym.fsf@gmail.com> (raw)
In-Reply-To: <87h7t16red.fsf@pc.i-did-not-set--mail-host-address--so-tickle-me>
Hi Christian,
Thanks for reporting this and providing a fix!
> The function `org-babel-python-evaluate-session' doesn't process temp
> file names with `org-babel-process-file-name' before inserting them into
> the Python code blocks. This causes a 'No such file' error when the
> executing the code blocks on a remote directory.
I tested this out and was able to reproduce the bug.
> The attached patch fixes this issue, allowing compilation of Python
> source blocks with a remote directory, such as :dir /ssh:user@server:/.
I tested your patch and it solves the problem.
> This is my first patch ever, so please let me know if there's ways I can
> improve.
The patch is pretty simple and I see no problems with it. Since it is so
small, FSF copyright assignment shouldn't be necessary. Also, it looks
like you followed all the guidelines on
https://orgmode.org/worg/org-contribute.html.
I'm fairly novice myself so will wait a couple days in case one of the
more experienced folks notices any issues here. But I'll merge this to
master by end of week if I don't hear anything.
next prev parent reply other threads:[~2020-08-18 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 18:47 [PATCH] ob-python.el: Fix issue with sessions on remote machines Christian Vanderwall
2020-08-18 14:21 ` Jack Kamm [this message]
2020-08-21 1:37 ` Jack Kamm
2020-09-04 9:55 ` Bastien
2020-09-05 1:08 ` Jack Kamm
2020-09-05 8:15 ` Bastien
2020-09-05 14:39 ` Jack Kamm
2020-09-05 14:48 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh6syqym.fsf@gmail.com \
--to=jackkamm@gmail.com \
--cc=christian@cvdub.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).