From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 7edkOFLWtV/sAgAA0tVLHw (envelope-from ) for ; Thu, 19 Nov 2020 02:20:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id FMkJNFLWtV+ICgAAbx9fmQ (envelope-from ) for ; Thu, 19 Nov 2020 02:20:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ADFCD9402A2 for ; Thu, 19 Nov 2020 02:20:01 +0000 (UTC) Received: from localhost ([::1]:54828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfZYF-0002FD-7Q for larch@yhetil.org; Wed, 18 Nov 2020 21:19:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfZXr-0002Ey-9z for emacs-orgmode@gnu.org; Wed, 18 Nov 2020 21:19:35 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:59574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfZXo-0006XD-Im for emacs-orgmode@gnu.org; Wed, 18 Nov 2020 21:19:34 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 4ACC092658; Wed, 18 Nov 2020 21:19:30 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=jA7nbiCv8HWXM+V7yVrk210yUfk=; b=LBDEuB Ov9GymSFZfownHDHTT/1PsHi/7GSbYbN8ILYTIN5et4eSNkBrGK7gfpLWBxP30gH aFCq/jQZfXYa3RLtCsaE9Q5DoyutfB8qbuouue0gza8NqD5vQPOMlPdqh6lSeiEO 08hUmjxqTc1nnhz6AVOWvIlZQeaYy+amrPHEQ= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 40F8292657; Wed, 18 Nov 2020 21:19:30 -0500 (EST) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=53q4jwCcnFDQYUYVucb2HCbaFoLE1P9AcOdVbgJr9A4=; b=HruUDsBCGAAtSG65pYYod4lZoughU/Idmdo63RUxXGQcVkDYXsOXf/7PGa8K+spVNy8//GdnyFDmhC/cgapjCOSSkzQdbGm871RHfxrhTUD1AK/LDRTRNhz7VWwWNdwXFlFEb9aI+9NRGMZDPUoZtMiGHhNQn8OdMMJOGjpNOnw= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id B56C492655; Wed, 18 Nov 2020 21:19:29 -0500 (EST) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: joakim@verona.se Subject: Re: problem with org-highest-priority In-Reply-To: <87sg96b99a.fsf@tanaka.verona.se> References: <878sckz66g.fsf@tanaka.verona.se> <87v9fovt34.fsf@kyleam.com> <87sg96b99a.fsf@tanaka.verona.se> Date: Wed, 18 Nov 2020 21:19:28 -0500 Message-ID: <87zh3e1427.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A7794A7A-2A0D-11EB-89B1-74DE23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/18 21:19:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=LBDEuB O; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=HruUDsBC; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: WEiFTGRk7QV1 joakim@verona.se writes: > Kyle Meyer writes: > >> The change in behavior you describe came with 4f98694bf (Allow numeric >> values for priorities, 2020-01-30). Based on quickly skimming that >> commit, I think the issue boils down to intentionally not supporting a >> mix of numbers and letters. I'm out of time tonight to look at it too >> closely, but I think support for your use case could be restored with >> something like the lightly tested patch below. > > Thanks, I tested your patch, and it helps a little bit. > > - m-x org-priority works, I can set any priority from 0 to Z > - org-priority-down and org-priority-down doesn't work as expected, as > they worked previously. I dont step through all the priority cookies, > instead I quickly wind up in prio 0, then I'm stuck there, for lack of > better description. Thanks for testing it out. I haven't really reloaded the issue into my head yet, but perhaps there's just a bit more to tweak then. > I'm not sure how to proceed. It seems I'm the only org-user affected by > this change? Hard to say, though I'd bet not (especially if we consider users that aren't on v9.4 yet). As for proceeding, with your feedback, I'll plan to take another look, but it won't be right away, so anyone is welcome to beat me to an updated patch. Even if your formerly working approach wasn't actually envisioned (*), I think it'd make sense to bring back support (along with tests) if it doesn't add much complication. (*) Again, I haven't refreshed on this issue, and I'm a very boring user of A, B, and C priorities. > Should I maintain a local patch to get the behaviour I > want? What is the recomended way to do that? I usually run > org-plus-contrib from elpa. I'm perhaps not the best person to answer this as a non-ELPA user, though I'd imagine your two main options are 1) defining org-priority in your local config to override the builtin version, either with a pure redefinition or with advice-add's :override. 2) cloning the Org repo and keeping a branch with the patch on top of the maint branch For maintaining a local variant over a longer period, the latter is the better way to go because you'll be alerted when the patched version conflicts. But let's see...