From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KM99FxgOvl+UBgAA0tVLHw (envelope-from ) for ; Wed, 25 Nov 2020 07:56:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id fLJUExgOvl9QJQAA1q6Kng (envelope-from ) for ; Wed, 25 Nov 2020 07:56:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A11A941D57 for ; Wed, 25 Nov 2020 07:46:01 +0000 (UTC) Received: from localhost ([::1]:44572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khpV0-0007Db-Vz for larch@yhetil.org; Wed, 25 Nov 2020 02:45:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khpUZ-0007DC-H0 for emacs-orgmode@gnu.org; Wed, 25 Nov 2020 02:45:31 -0500 Received: from mailer-211-145.hitrost.net ([91.185.211.145]:61977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khpUX-0007wb-BJ for emacs-orgmode@gnu.org; Wed, 25 Nov 2020 02:45:30 -0500 Received: from lk.84.20.244.182.dc.cable.static.lj-kabel.net ([84.20.244.182] helo=Tauriel) by b1.hitrost.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1khpUN-009Zty-HP; Wed, 25 Nov 2020 08:45:19 +0100 References: <48c15b01-341d-f4c6-7086-1a39e4977868@grinta.net> <87h7pgvk6b.fsf@kyleam.com> <938fa4a5-f162-6c03-072b-4f11546a95c8@grinta.net> <87blfnso8w.fsf@kyleam.com> <87sg8z8ggc.fsf@kyleam.com> <47de3641-501b-5d47-5aa9-a28ddc25e037@grinta.net> <87lfeq89zm.fsf@kyleam.com> User-agent: mu4e 0.9.19; emacs 25.3.2 From: Christian Moe To: Kyle Meyer Subject: Re: [PATCH] org-table: Add mode flag to enable Calc units simplification mode In-reply-to: <87lfeq89zm.fsf@kyleam.com> Date: Wed, 25 Nov 2020 08:41:48 +0100 Message-ID: <87zh3551dv.fsf@christianmoe.com> MIME-Version: 1.0 Content-Type: text/plain X-GeoIP: Country [IP], SI [84.20.244.182] X-Antivirus-Scanner: Clean mail though you should still use an Antivirus Received-SPF: pass client-ip=91.185.211.145; envelope-from=mail@christianmoe.com; helo=mailer-211-145.hitrost.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode List , Daniele Nicolodi Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: GOyB8JXAL21M Great! Thanks for following through on this, Dan! Yours, Christian Kyle Meyer writes: > Daniele Nicolodi writes: > >> Thank you for the review, Kyle. >> >> Another updated patch set is attached. > > Thank you for the update. > > Applied, tweaking the manual entry to use "a unit" rather than "an > unit". > > 1: bd7e16ca2 = 1: bd7e16ca2 org-table: Remove unused org-tbl-calc-modes variable declaration > 2: abd994943 = 2: abd994943 org-table: Simplify mode string parsing > 3: cb77e7a46 ! 3: 15469774d org-table: Add mode flag to enable Calc units simplification mode > @@ doc/org-manual.org: *** Formula syntax for Calc > +- =u= :: > + > + Units simplification mode of Calc. Calc is also a symbolic > -+ calculator and is capable of working with values having an unit, > -+ represented with numerals followed by an unit string in Org table > ++ calculator and is capable of working with values having a unit, > ++ represented with numerals followed by a unit string in Org table > + cells. This mode instructs Calc to simplify the units in the > + computed expression before returning the result. > +