From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id IL57GVH71l9WJQAA0tVLHw (envelope-from ) for ; Mon, 14 Dec 2020 05:42:41 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YBBNFVH71l+IJQAA1q6Kng (envelope-from ) for ; Mon, 14 Dec 2020 05:42:41 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EAFFE9401BC for ; Mon, 14 Dec 2020 05:42:40 +0000 (UTC) Received: from localhost ([::1]:50634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kogd4-0007Xb-8Q for larch@yhetil.org; Mon, 14 Dec 2020 00:42:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kogcT-0007XV-Ah for emacs-orgmode@gnu.org; Mon, 14 Dec 2020 00:42:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47184) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kogcT-0001Pm-3o; Mon, 14 Dec 2020 00:42:01 -0500 Received: from lns-bzn-32-82-254-31-120.adsl.proxad.net ([82.254.31.120]:58200 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kogcS-0003FD-Qj; Mon, 14 Dec 2020 00:42:00 -0500 Received: by guerry (Postfix, from userid 1000) id A0C551A60435; Mon, 14 Dec 2020 06:41:58 +0100 (CET) From: Bastien To: TEC Subject: Re: [PATCH] org-plot abstractions and extension References: <87imcrfntf.fsf@gmail.com> <87blijmnv9.fsf@gnu.org> <87lfhbhfhe.fsf@gmail.com> <87r1qp3fu1.fsf@gmail.com> <871rhxd2ib.fsf@gmail.com> <87r1pnoo5y.fsf@bzg.fr> <87lffv8oy5.fsf@gmail.com> Date: Mon, 14 Dec 2020 06:41:58 +0100 In-Reply-To: <87lffv8oy5.fsf@gmail.com> (TEC's message of "Sun, 25 Oct 2020 02:16:08 +0800") Message-ID: <87zh2hosex.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.80 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: EAFFE9401BC X-Spam-Score: -2.80 X-Migadu-Scanner: scn1.migadu.com X-TUID: yycvTVYMb7YR Hi Timothy, TEC writes: > I'll attach all the patches to this email, so there's no ambiguity. > (crosses fingers for attachments working as expected) Applied, with minor modifications of the changelog entries: - You need to add an entry when creating a new custom variable. - I suggest saying "option" instead of "custom variable". - Sentences should be separated by two spaces and start with an uppercase letter. Also, the convention in Emacs is to avoid whitespaces-only commits, you need to fix whitespaces within other non-whitespaces changes in a commit. Thanks a lot! -- Bastien