From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YBpqAlRUfmKI4QAAbAwnHQ (envelope-from ) for ; Fri, 13 May 2022 14:51:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GOteAlRUfmInlgAA9RJhRA (envelope-from ) for ; Fri, 13 May 2022 14:51:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A4F20FD55 for ; Fri, 13 May 2022 14:51:31 +0200 (CEST) Received: from localhost ([::1]:52596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npUlW-0002Vn-IJ for larch@yhetil.org; Fri, 13 May 2022 08:51:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npUHp-0003oB-Ld for emacs-orgmode@gnu.org; Fri, 13 May 2022 08:20:50 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:39435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npUHn-00064p-Q8 for emacs-orgmode@gnu.org; Fri, 13 May 2022 08:20:49 -0400 Received: by mail-pl1-x635.google.com with SMTP id x18so7770516plg.6 for ; Fri, 13 May 2022 05:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=tFUdlZ0BTIjAM30jBwv4d44XIaaPiUAjXJbyUIC+I/o=; b=Lum+WVqL3m0cdyp2CGpMiyFNlte5vid1Toe75vh89rGhUhMLgDCrB3OGiO7wES+aXg S1SYd5Frw6Z96IFRTNACS6o3iOn69Zo7g1GT1TBnIP3wwxcMKvfQZA24ybfLkzW9Odyd Cu6l1FG2fHFiyKEb7genxadBZwtkU8PjqQYuPrqLOfDwVoDbz/7cJ21szMheVXA9mlWF b5HzWz+XVw651f6z8sRo5cl4srOAkRdJ9BX721PB18TgNy6wGDq75WHaMKJWMlLSmfou pkY2FFFXuVuiRY5pOPxTNLJUGE8xqXnta0Mn6un4u0Qkf7eCblM2X+ck7MFMJtyXFXpO TlAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=tFUdlZ0BTIjAM30jBwv4d44XIaaPiUAjXJbyUIC+I/o=; b=AjLj9/O90qUpeszyzFvX6sAJx2mS/1CCZacoK/6ybKUuraoCRLFTPrAfwbozp4oiIL NlyyoOM+VQ1gJ55Iwb6XvPkBC/3O/42QjmxeUaziAbNV0x5kdwvKcS/pgwyT1c9ZQ5ru 7Eq9jb9cAOIa3Hz0fLDLygdAqdskX3YmTJwMrR9HGzLuVIs3slKDkvSKqhBMG8zuFyvw R8lhGNd1JtQImHw/jFMaI98o6/bvO5x+7NRMwFHDzo538GAvwI9fA38ot2Vzymq96VJk gTvtOzl35NlqNHdxBh2QDPpixdoO5CSpXYgIzxpvAFflQY8LllemGbBaNLQDISxV6kml DvVA== X-Gm-Message-State: AOAM532gyFryLcHcgTac/1c9FPc/ruvfReWAcRLhWFS9pI+eHtXT/WxU Rf2RiSLK4WjFgMqksNcRhRE= X-Google-Smtp-Source: ABdhPJwniI96w7xOgSKKf8EFd1qEMffLGTcZagnrxNkq7BPNnLNv+p7HC3LfoxCMyRQ0MWYaCleYHA== X-Received: by 2002:a17:90b:3a89:b0:1de:bad4:b614 with SMTP id om9-20020a17090b3a8900b001debad4b614mr15959219pjb.139.1652444445268; Fri, 13 May 2022 05:20:45 -0700 (PDT) Received: from localhost ([37.120.210.2]) by smtp.gmail.com with ESMTPSA id h188-20020a62dec5000000b0050dc762816esm1623299pfg.72.2022.05.13.05.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 05:20:44 -0700 (PDT) From: Ihor Radchenko To: Tyler Grinn Cc: org-mode-email Subject: Re: [PATCH] Re: Concatenate properties In-Reply-To: <87mtfmib6r.fsf@gmail.com> References: <87y1zfk3ls.fsf@gmail.com> <87zgjuis8z.fsf@gmail.com> <87pmkpykiz.fsf@localhost> <87v8uhikzx.fsf@gmail.com> <87sfpkqkos.fsf@localhost> <87zgjst8lq.fsf@gmail.com> <877d6wqdxs.fsf@localhost> <87mtfq8np8.fsf@gmail.com> <87czgkjnit.fsf@localhost> <874k1w2c6o.fsf_-_@gmail.com> <87czgjhy0m.fsf@localhost> <87mtfmib6r.fsf@gmail.com> Date: Fri, 13 May 2022 20:21:28 +0800 Message-ID: <87zgjlpqrb.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=yantar92@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652446291; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=tFUdlZ0BTIjAM30jBwv4d44XIaaPiUAjXJbyUIC+I/o=; b=cfvH+/LAy3PtLzbFpSs0zlGd4DYR2AqEsefoopy0Bqxb50zO2xD+TY6YVS4ISBfT36BScl 3h90akBAuw0zztFIVzG/ucpIW0ZCFRiGkFVtGzk02ZBiZH7kaur30ZjN7D8z5QbN0TXyd8 sBpY6TFrK5ee2J0oimAN1MxVJaThevw7J51gxFizX5B9ptaldpmWk7LmkmHkOL2ZPjxmVM hisQAlDrA80wGEqT1EE0qB5OfiTVUw9Kfiejhs9pVGQCunUknuG+/3gYEIn9vNKJ4c9h9u fH5KiiFMpKgGE5Y+1R0VjOr1mc9eZip8mFBtP+D5562m86uqhZAoZLpBuOJtCA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652446291; a=rsa-sha256; cv=none; b=cBHSp8GLfkiTZFvFRL8axA7gYyrVIapJNDUYTAiOxtecK8XrKtwVCLqNOOGLxNj6w0Vaui Faz+fCzOCMu+AGHSJHbmWWPbKxxWJPHkNQIoDuFzl22qP+lva5T+vg+PuZHiu++lZIJRqW GOUtWSTiG6K8EAQS6lTnpEkYycyqL1tNPr0xbhz+LealjRocSFWDaEAxHl/dfz44SOyitU 7yfTsQlzdy81TQ9QgsMIqwKWwm+QZZFHv0LHIZVNt4USrXTZkSRhFtEp2UFd4Y0f484nS/ s+zQFXdlsFS0Ieg8SqQZtZAklBTUxAU3ICHCUNiafEYHOeY5+W01XNySaLTyDw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lum+WVqL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.62 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Lum+WVqL; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A4F20FD55 X-Spam-Score: -8.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: j49bQ0KbyS+e Tyler Grinn writes: > Ihor Radchenko writes: > >> Note that your patch is >15LOC long and you need to sign the copyright >> agreement with FSF in order to contribute. See >> https://orgmode.org/worg/org-contribute.html#copyright > > I've already submitted a copyright assignment to the FSF in order to > publish on ELPA. Do I need one specific to org-mode? Nope. The ELPA one is good enough. Basically, Org has the same requirement as Emacs (Org is a part of Emacs). >>> +(defcustom org-property-separators nil >>> ... >>> + :group 'org-properties >>> + :type '(alist :key-type string :value-type sexp)) >> >> This defcustom type does not match what you described in the docstring. >> You need something like :type '(alist :key-type (choice string (repeat string)) :value-type string) > > Setting ':value-type string' is confusing, in my opinion, because the > default single space looks like: in the customization buffer, which is > indistinguishable from no space: . I just found out about the restricted-sexp > type, which I think makes the customization buffer more user-friendly. restricted-sexp is fine. Though you could also do something like (choice (const :tag "Single space" " ") (string :tag "Other string")) > From f474cb25840fdc6b24618b1452cb7fdd32545092 Mon Sep 17 00:00:00 2001 > From: Tyler Grinn > Date: Mon, 9 May 2022 15:52:58 -0400 > Subject: [PATCH] lisp/org.el: Add org-property-separators option LGTM! I will leave this for another week to give other people a chance to comment. For reference, this patch might be useful in https://orgmode.org/list/87o821dv7o.fsf@localhost Best, Ihor