emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Tyler Grinn <tylergrinn@gmail.com>
Cc: org-mode-email <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Re: Concatenate properties
Date: Fri, 13 May 2022 20:21:28 +0800	[thread overview]
Message-ID: <87zgjlpqrb.fsf@localhost> (raw)
In-Reply-To: <87mtfmib6r.fsf@gmail.com>

Tyler Grinn <tylergrinn@gmail.com> writes:

> Ihor Radchenko <yantar92@gmail.com> writes:
>
>> Note that your patch is >15LOC long and you need to sign the copyright
>> agreement with FSF in order to contribute. See
>> https://orgmode.org/worg/org-contribute.html#copyright
>
> I've already submitted a copyright assignment to the FSF in order to
> publish on ELPA. Do I need one specific to org-mode?

Nope. The ELPA one is good enough. Basically, Org has the same
requirement as Emacs (Org is a part of Emacs).

>>> +(defcustom org-property-separators nil
>>> ...
>>> +  :group 'org-properties
>>> +  :type '(alist :key-type string :value-type sexp))
>>
>> This defcustom type does not match what you described in the docstring.
>> You need something like :type '(alist :key-type (choice string (repeat string)) :value-type string)
>
> Setting ':value-type string' is confusing, in my opinion, because the
> default single space looks like:   in the customization buffer, which is
> indistinguishable from no space: . I just found out about the restricted-sexp
> type, which I think makes the customization buffer more user-friendly.

restricted-sexp is fine. Though you could also do something like
(choice (const :tag "Single space" " ") (string :tag "Other string"))

> From f474cb25840fdc6b24618b1452cb7fdd32545092 Mon Sep 17 00:00:00 2001
> From: Tyler Grinn <tylergrinn@gmail.com>
> Date: Mon, 9 May 2022 15:52:58 -0400
> Subject: [PATCH] lisp/org.el: Add org-property-separators option

LGTM!

I will leave this for another week to give other people a chance to
comment.

For reference, this patch might be useful in https://orgmode.org/list/87o821dv7o.fsf@localhost

Best,
Ihor



  reply	other threads:[~2022-05-13 12:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 22:37 Concatenate properties Tyler Grinn
2022-05-05 22:56 ` John Kitchin
2022-05-06 15:40   ` Tyler Grinn
2022-05-07  5:33     ` Ihor Radchenko
2022-05-07 11:44       ` John Kitchin
2022-05-07 12:29         ` Tyler Grinn
2022-05-08 12:21           ` Ihor Radchenko
2022-05-08 14:14             ` Tyler Grinn
2022-05-08 14:47               ` Ihor Radchenko
2022-05-09 20:18                 ` Tyler Grinn
2022-05-11 11:51                   ` Ihor Radchenko
2022-05-11 17:47                     ` [PATCH] " Tyler Grinn
2022-05-12  9:59                       ` Ihor Radchenko
2022-05-12 23:27                         ` Tyler Grinn
2022-05-13 12:21                           ` Ihor Radchenko [this message]
2022-05-14  2:11                             ` Tyler Grinn
2022-05-20  8:04                             ` Ihor Radchenko
2022-05-07 13:20     ` John Kitchin
2022-05-07 14:09       ` Tyler Grinn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgjlpqrb.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=tylergrinn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).