emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Allen Li <darkfeline@felesatra.moe>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]
Date: Sun, 26 Jun 2022 12:49:38 +0800	[thread overview]
Message-ID: <87zgi02fml.fsf@localhost> (raw)
In-Reply-To: <CADbSrJwUcib4T00nk3vmBfOiJFzMT-15Gw=9jmzLRQwGKTPGXA@mail.gmail.com>

Allen Li <darkfeline@felesatra.moe> writes:

>> Would you also be interested to write a test checking org-todo ARGS?
>>
>
> Attached

Thanks! However, it is unclear what this test is checking for.

> +(ert-deftest test-org/org-todo-prefix ()
> +  "Test `org-todo' prefix arg behavior."
> +  ;; -1 prefix arg should cancel repeater and mark DONE.
> +  (should-not
> +   (string-prefix-p
> +    "* TODO H"
> +    (let ((org-todo-keywords '((sequence "TODO" "DONE"))))
> +      (org-test-with-temp-text "* TODO H\n<2012-03-29 Thu +2y>"
> +	                       (org-todo -1)
> +	                       (buffer-string)))))

This test does not check if the task is actually marked DONE and also
does not check if the repeater is canceled.

Best,
Ihor



  reply	other threads:[~2022-06-26  4:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-01  9:31 [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)] Allen Li
2022-01-01  9:44 ` Allen Li
2022-02-07 14:11   ` Ihor Radchenko
2022-06-18  6:10     ` Ihor Radchenko
2022-06-26  4:30       ` Allen Li
2022-06-26  4:49         ` Ihor Radchenko [this message]
2022-06-26  5:41           ` Allen Li
2022-06-26  6:31             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgi02fml.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=darkfeline@felesatra.moe \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).