[PATCH] org-fast-tag-selection: Make group tags separator not break alignment

[Ihor Radchenko <yantar92@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

"Christopher M. Miles" <numbchild@gmail.com> writes:

> I agree to improve the tag selection UI. The hard-to-type characters is
> not necessary. It's hard to type, and not match the purpose of "fast tag
> selection", and will break tags alignment.
>
> Also need minor improvement on alignment of tags "group tag".
>
> Please see my screenshot attachment.

This should be easy. See the attached patch.
Note that the patch does not consider a case of narrow screen, but it is
not like the menu is designed with such considerations, so I do not see
much point trying hard to cover the edge cases.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-fast-tag-selection-Make-group-tags-separator-not.patch --]
[-- Type: text/x-patch, Size: 1134 bytes --]

From 1cd18001f982092534664bc257b470fd9855b839 Mon Sep 17 00:00:00 2001
Message-Id: <1cd18001f982092534664bc257b470fd9855b839.1659965569.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Mon, 8 Aug 2022 21:30:04 +0800
Subject: [PATCH] org-fast-tag-selection: Make group tags separator not break
 alignment

* lisp/org.el (org-fast-tag-selection): Start " : " group tags
separator before tag column in the menu.

Reported in https://orgmode.org/list/62f04f7c.d40a0220.9da67.0a2cSMTPIN_ADDED_BROKEN@mx.google.com
---
 lisp/org.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/org.el b/lisp/org.el
index 3b1caecf1..f7625dac7 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -11749,7 +11749,9 @@ (defun org-fast-tag-selection (current inherited table &optional todo-table)
 	      (while (equal (car tbl) '(:newline))
 		(insert "\n")
 		(setq tbl (cdr tbl)))))
-	   ((equal e '(:grouptags)) (insert " : "))
+	   ((equal e '(:grouptags))
+            (delete-backward-char 3)
+            (insert " : "))
 	   (t
 	    (setq tg (copy-sequence (car e)) c2 nil)
 	    (if (cdr e)
-- 
2.35.1