From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id NnGHMcqXKmOAdgAAbAwnHQ (envelope-from ) for ; Wed, 21 Sep 2022 06:49:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qECbMMqXKmMc6wAA9RJhRA (envelope-from ) for ; Wed, 21 Sep 2022 06:49:14 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6AFB766DC for ; Wed, 21 Sep 2022 06:49:14 +0200 (CEST) Received: from localhost ([::1]:47366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oarfd-0004mQ-1w for larch@yhetil.org; Wed, 21 Sep 2022 00:49:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oarct-0004ja-Bl for emacs-orgmode@gnu.org; Wed, 21 Sep 2022 00:46:23 -0400 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]:41968) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oarcq-0005Ux-SJ for emacs-orgmode@gnu.org; Wed, 21 Sep 2022 00:46:23 -0400 Received: by mail-pg1-x535.google.com with SMTP id q9so4760604pgq.8 for ; Tue, 20 Sep 2022 21:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=s+XR79UINWIL/NuXH0kYnC8G8sQ59oxK/PnNEivnO9I=; b=eGL60FFboYD8dUwn6dKw6vldpCh4e7K9YrqCgZDiQkE9RyxBylqp4sQZE0W8GG2C6Y yiL1ioEFt3jPiAr0s5CIOjl2Yd1I5tyN6vRXlnn3aVhpd6pcbqCL4H1G8l9dbswSXsYp +3WXWzBnrr7NcVftOHOrf/RD3Mdzh8VTGXzxRhr6n0GgfsAU70SkCOwqMNfU2VD+Le+X EoLsSX1RO0pNX8NicWDfu0dK04qcMXUH65sf7gjFKM7SKNQZ2ZYtMHP0WnqQ9B1Xfkhe u6qE/svSFdmVkiT6kaw8taMejE0IJUX4ajMZIYApSaw6pRY8l8Y7pmcb/zxrhur36YA0 G5tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=s+XR79UINWIL/NuXH0kYnC8G8sQ59oxK/PnNEivnO9I=; b=Therz2EnyBIgfp9nyhOgaCnKZWvcW4T9t9NbkY0KEuIFNpVZbsxjAbwvrTX2/mB6hs urjsz1KrYziW8jKCGXoh43LA5NsRkSLR6U7Jqh++vL9mDXqeczjOSbZAaYvJqN5M+l96 AlE+yQ38MxJfvKHC/4CK55vqZ1PhQIgz6mnW+4pWE1kAZLL8oQaGkjSB9RIa5kM/dlU+ MfOISQaAKgjPJbVWwsoQv+rglA6oLxOJoVd6ydRov750DNvwNv3myzzx8UnKOpVmllLC Gte3va5+FHHdlYu8adJodWtBq1dGMhA3tQgU77T+J8ujD/TIYyZPZWBMVfE2uJ84GFvQ 6XDw== X-Gm-Message-State: ACrzQf0KWG0rQEZsZqudHnEn+WhHrCjEpOFNF4F1BaDxqiEH4QF+UNlG kaAU7NEZvxwbA5Kyvm2utvM= X-Google-Smtp-Source: AMsMyM7wcYYXl5UQRgnsNnabxl6Dho6bo4Zxf5fDUx9yOOmNtj+Ythvn3SaJ5oeoZxWwGWW7++AHCA== X-Received: by 2002:a63:6948:0:b0:433:5e5b:54b2 with SMTP id e69-20020a636948000000b004335e5b54b2mr22868511pgc.286.1663735575142; Tue, 20 Sep 2022 21:46:15 -0700 (PDT) Received: from localhost ([1.83.154.224]) by smtp.gmail.com with ESMTPSA id r10-20020aa79eca000000b0053e34dcfe7dsm877775pfq.149.2022.09.20.21.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 21:46:13 -0700 (PDT) From: Ihor Radchenko To: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-agenda-list takes 4m compared to 27 that took 15 seconds [9.5.2 (release_9.5.2-25-gaf6f12 @ /usr/share/emacs/28.1/lisp/org/)] In-Reply-To: References: <87wnaeo18w.fsf@localhost> <8735cwujed.fsf@localhost> <87k068t1qf.fsf@localhost> <87h71bdgr3.fsf@localhost> <87wna6ya45.fsf@localhost> <87v8poszqb.fsf@localhost> <87tu52z3j6.fsf@localhost> <8735cmyx0s.fsf@localhost> Date: Wed, 21 Sep 2022 12:47:07 +0800 Message-ID: <87zgetxrjo.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::535; envelope-from=yantar92@gmail.com; helo=mail-pg1-x535.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663735754; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=s+XR79UINWIL/NuXH0kYnC8G8sQ59oxK/PnNEivnO9I=; b=dbAnRF8i9miHunlJiK2SuQzDv5N2oSznQig5Vp3HC8NoaqxKGjP/OLrHwgLvA8OWBDZmpQ X1v8cabKqGzxIrzi/PjRacYmXb6Z+prBouKoc2ZuNM05jJtIw9rOlnEnn9nbc8vhFyPeOD SqDenocIssY4ru0JQv0DzGZ6cLnnyVYfJUIXB5ekvlfsF0+noV2FOPqfM7ZuTymM7dufRq gMngtD2ub6KWjFPISj7J+unddxXQs/isqmdbU0tsWB4Xk72qWRLr8qVlPKK+hu1jAqCord nVUo8WjUPz+cvMS/Kt9dbTGkShpRqiUXalw/WgSaNUYo2zz30Nh48ZcgCKjPYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663735754; a=rsa-sha256; cv=none; b=eMjN08jAZSLZQHa2RR/e5u44IRvwo7s1ssdPXGFDRdEQfW8Z03QBeZGcdIqU7PszbYFihI AU4KFChFSwNYL93DSFu/28YmPJDEChosniEQbDsrEI8f+HiHiZ4PndyvAOTo4HYc3gqIjQ wtpLe1Xu7khFPWf65VWtfHfohYX9p7ylUzRJpPTQ+X5ZRltPs6lSEBYmUK/TV0n8YGzZCy zU3NY5Y52UxOayTGxNrnj3BzEXtXd+PGWJMeDwFdHgxiasWR9EYcdf0jHEB5jUDw5ZOsAE BIW4n6asGnoArl3oGiL7dKpRMaNMifuYPJp24828tYFOCdcv4GnI2AN6usHXhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eGL60FFb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.34 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eGL60FFb; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6AFB766DC X-Spam-Score: -3.34 X-Migadu-Scanner: scn1.migadu.com X-TUID: TsSMWHB6SpZk andr=C3=A9s ram=C3=ADrez writes: > Ihor> This does not make sense. According to your profiler, you are = still using an older > Ihor> version of org-in-src-block-p function. Can you please make sur= e that no obsolete .elc > Ihor> files are present in the Org distribution? (you can run make) > > My mistake. I attached the previous file. Sending now the correct file. Thanks! > >> Just out of curiosity. which bug or improvement or new feature on = agenda caused this delay on > >> showing the agenda buffer?. > > Ihor> Previously, determining if diary sexp is located inside src blo= ck (and thus must not be > Ihor> considered a valid match) was done (incorrectly) relying on fon= tification. That bug has > Ihor> been fixed to ensure correctness at the cost of performance deg= radation. > > Too bad. On my case my agenda files does not have src-block's > inside. could I set a variable telling it. For avoiding such penalty?. No. This will be against Org syntax. You may advice `org-agenda-skip' function let-binding `org-in-src-block-p' to #'ignore. At your own risk. Also, we may remove this check in future in favour of more reliable `org-element-context'. But not yet. That function is currently slower compared to `org-in-src-block-p'. > Ihor> It would be interesting to see the profiler results in emacs27. > > Sending the emacs27 profiler too. Do You think It would be relevant doing= the > same with emacs-28? What do you mean? I thought that you were testing newest Org + emacs-28. Comparing the profiler reports, I also noticed that an additional overhead is coming from the new library loaded in org-modules. We have added 'ol-doi default module. You may remove unused libraries from org-modules to speed up the initial startup (there will be no difference in agenda rebuild times). I also pushed a couple of new small optimizations, according to your profiler report. Can you try again with the latest main? BTW, is your Emacs 28 using native-comp? --=20 Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92