emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: "andrés ramírez" <rrandresf@hotmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-agenda-list takes 4m compared to 27 that took 15 seconds [9.5.2 (release_9.5.2-25-gaf6f12 @ /usr/share/emacs/28.1/lisp/org/)]
Date: Wed, 21 Sep 2022 12:47:07 +0800	[thread overview]
Message-ID: <87zgetxrjo.fsf@localhost> (raw)
In-Reply-To: <SJ1PR12MB6363ED84E5EA48EECBE95FA8A64C9@SJ1PR12MB6363.namprd12.prod.outlook.com>

andrés ramírez <rrandresf@hotmail.com> writes:

>     Ihor> This does not make sense.  According to your profiler, you are still using an older
>     Ihor> version of org-in-src-block-p function. Can you please make sure that no obsolete .elc
>     Ihor> files are present in the Org distribution? (you can run make)
>
> My mistake. I attached the previous file. Sending now the correct file.

Thanks!

>     >> Just out of curiosity. which bug or improvement or new feature on agenda caused this delay on
>     >> showing the agenda buffer?.
>
>     Ihor> Previously, determining if diary sexp is located inside src block (and thus must not be
>     Ihor> considered a valid match) was done (incorrectly) relying on fontification. That bug has
>     Ihor> been fixed to ensure correctness at the cost of performance degradation.
>
> Too bad. On my case my agenda files does not have src-block's
> inside. could I set a variable telling it. For avoiding such penalty?.

No. This will be against Org syntax.
You may advice `org-agenda-skip' function let-binding
`org-in-src-block-p' to #'ignore. At your own risk.

Also, we may remove this check in future in favour of
more reliable `org-element-context'. But not yet. That function is
currently slower compared to `org-in-src-block-p'.

>     Ihor> It would be interesting to see the profiler results in emacs27.
>
> Sending the emacs27 profiler too. Do You think It would be relevant doing the
> same with emacs-28?

What do you mean? I thought that you were testing newest Org + emacs-28.

Comparing the profiler reports, I also noticed that an additional
overhead is coming from the new library loaded in org-modules.
We have added 'ol-doi default module. You may remove unused libraries
from org-modules to speed up the initial startup (there will be no
difference in agenda rebuild times).

I also pushed a couple of new small optimizations, according to your
profiler report. Can you try again with the latest main?

BTW, is your Emacs 28 using native-comp?

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


  reply	other threads:[~2022-09-21  4:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 17:02 [BUG] org-agenda-list takes 4m compared to 27 that took 15 seconds [9.5.2 (release_9.5.2-25-gaf6f12 @ /usr/share/emacs/28.1/lisp/org/)] Andrés Ramírez
2022-09-08  5:59 ` Ihor Radchenko
2022-09-12 17:55   ` andrés ramírez
2022-09-13  1:56     ` Ihor Radchenko
2022-09-13  2:53       ` andrés ramírez
2022-09-13  3:03         ` Ihor Radchenko
2022-09-13  4:00           ` andrés ramírez
2022-09-13  4:45             ` Ihor Radchenko
2022-09-13 23:29               ` andrés ramírez
2022-09-14  2:15                 ` Ihor Radchenko
2022-09-14 16:30                   ` andrés ramírez
2022-09-16  4:35                     ` Ihor Radchenko
2022-09-16 11:31                       ` andrés ramírez
2022-09-20 11:30                         ` Ihor Radchenko
2022-09-20 13:28                           ` andrés ramírez
2022-09-20 13:51                             ` Ihor Radchenko
2022-09-20 14:51                               ` andrés ramírez
2022-09-21  4:47                                 ` Ihor Radchenko [this message]
2022-09-22  1:59                                   ` andrés ramírez
2022-09-22  3:32                                     ` Ihor Radchenko
2022-09-22  4:27                                       ` andrés ramírez
2022-09-22  4:44                                         ` Ihor Radchenko
2022-09-22  5:00                                           ` andrés ramírez
2022-09-22  5:04                                             ` Ihor Radchenko
2022-09-22 13:23                                               ` andrés ramírez
2022-09-23  3:05                                                 ` Ihor Radchenko
2022-09-23  3:19                                                   ` andrés ramírez
2022-09-23  3:35                                                     ` Ihor Radchenko
2022-09-23  3:57                                                       ` andrés ramírez
2022-09-23  5:11                                                         ` Ihor Radchenko
2022-09-23 14:55                                                           ` andrés ramírez
2022-09-23 15:36                                                             ` Ihor Radchenko
2022-09-23 16:14                                                               ` andrés ramírez
2022-09-23 17:08                                                                 ` Fraga, Eric
2022-09-23 17:23                                                                   ` andrés ramírez
2022-09-24  3:20                                                                     ` Ihor Radchenko
2022-09-24  4:10                                                                       ` on picking diary-style timestamps or normal timestamps when adding agenda entries (was: [BUG] org-agenda-list takes 4m compared to 27 that took 15 seconds [9.5.2 (release_9.5.2-25-gaf6f12 @ /usr/share/emacs/28.1/lisp/org/)]) andrés ramírez
2022-09-24  4:34                                                                         ` Ihor Radchenko
2022-09-26 16:37                                                                           ` andrés ramírez
2022-09-27  2:38                                                                             ` Ihor Radchenko
2022-09-27  2:59                                                                               ` on picking diary-style timestamps or normal timestamps when adding agenda entries andrés ramírez
2022-09-27  3:21                                                                                 ` Ihor Radchenko
2022-09-23 16:33                                                   ` [BUG] org-agenda-list takes 4m compared to 27 that took 15 seconds [9.5.2 (release_9.5.2-25-gaf6f12 @ /usr/share/emacs/28.1/lisp/org/)] Max Nikulin
2022-09-24  3:28                                                     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgetxrjo.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=rrandresf@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).