Re: [PATCH] Re: Update Org to MathJax 3

[Ihor Radchenko <yantar92@posteo.net>]

Rudolf Adamkovič <salutis@me.com> writes:

> Rudolf Adamkovič <salutis@me.com> writes:
>
>> See the 4th version of the patch attached below.
>
> And, of course, I forgot to update the commit message with the new
> macro.  Please see the 5th version of the patch attached below.

Thanks!

>  with Org[fn:: By default Org loads MathJax from
> -[[https://cdnjs.com][cdnjs.com]] as recommended by
> +[[https://www.jsdelivr.com/][jsDelivr]] as recommended by
>  [[https://www.mathjax.org][MathJax]].][fn:46].  Some MathJax display

Is it really recommended by mathjax? I cannot find any mention of
jsdelivr.com. You may update the URL to something more precise.

>  #+texinfo: @noindent
>  equation labels are displayed on the left margin and equations are
> -five em from the left margin.  In addition, it loads the two MathJax
> -extensions =cancel.js= and =noErrors.js=[fn:: See
> -[[https://docs.mathjax.org/en/latest/input/tex/extensions.html#tex-and-latex-extensions][TeX
> -and LaTeX extensions]] in the [[https://docs.mathjax.org][MathJax
> -manual]] to learn about extensions.].
> +five em from the left margin.

Are these extensions no longer supported?
  
> -	  (options (plist-get info :html-mathjax-options))
> +	  (options (let ((options (plist-get info :html-mathjax-options)))
> +                     ;; If the user customized some legacy option, set
> +                     ;; the corresponding new option to nil, so that
> +                     ;; the legacy user choice overrides the default.
> +                     ;; Otherwise, the user did not set the legacy
> +                     ;; option, in which case still set the legacy
> +                     ;; option but to no value, so that the code can
> +                     ;; find its in-buffer value, if set.
> +                     (append
> +                      (list (list (if (plist-member options 'autonumber)
> +                                      'tags 'autonumber)
> +                                  nil)
> +                            (list (if (plist-member options 'linebreaks)
> +                                      'overflow 'linebreaks)
> +                                  nil))
> +                      options)))

It would be more compact to use `(...) notation.
 
> +(defmacro org-test-capture-messages (&rest body)
> +  "Return the list of all messages put in the echo area by the BODY."
> +  ;; TODO Despite its name, this macro has nothing to do with Org and
> +  ;; belongs to a more general package in Emacs.
> +  (declare (indent 0) (debug t))
> +  `(let ((messages (list)))
> +     (cl-letf (((symbol-function 'message)
> +                (lambda (format-string &rest args)
> +                  (setq messages
> +                        (cons (apply #'format
> +                                     (cons format-string
> +                                           args))
> +                              messages)))))
> +       ,@body)
> +     (reverse messages)))

nreverse will be more memory-efficient.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>