From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yPYqOctUxWOEHgEAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 14:44:44 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sBQDOMtUxWN4KgEAG6o9tA (envelope-from ) for ; Mon, 16 Jan 2023 14:44:43 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C3524FDEF for ; Mon, 16 Jan 2023 14:44:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHPmC-00046Y-TK; Mon, 16 Jan 2023 08:43:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHPm9-000465-Nm for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 08:43:51 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHPm7-0004E7-EH for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 08:43:49 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CF56E2400DC for ; Mon, 16 Jan 2023 14:43:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673876624; bh=2XLk7ZPOH1ZzSnXNGqCLh/vrj9VSJ4LO430MdVuh2J8=; h=From:To:Cc:Subject:Date:From; b=Ts0bLZaIR7pvRwzDmKTWK8yNvo8WGxlyXzbw6/fu8Q2IQmNFvAMbBmoJoZd33IePL K1GTrGzS0Z0u+al1fxuZfkJ1tyomOlP1vl2TnNp1DLUnphriTnqH5OwqADqdGgGTtH 4lYaqh+WW1doxAHbrcEos6EYE29D6KHTtGaj6d9e0uJF/ncz2iclakG/DAbUNXu293 8y74IXAtqiWGt66cVOoQvMIjFkxr7365x4ai7EEXXUki4BeE/8cnEjlh5VxIBVjVMm xotTs0BgOkURIoL+gHMGEiN4b++iMWAH4wtSDq9+V3KGziAG4U66Pv7BQq+ccSD+99 wGVx8OzyzsM6A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NwYC35kjXz6tmd; Mon, 16 Jan 2023 14:43:43 +0100 (CET) From: Ihor Radchenko To: Tom Gillespie Cc: emacs-orgmode Subject: Re: [PATCH] fix compat with emacs 25 due using temporary-file-directory In-Reply-To: References: Date: Mon, 16 Jan 2023 13:44:14 +0000 Message-ID: <87zgaik30x.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673876658; a=rsa-sha256; cv=none; b=IPen70iSHZ/CQf+DgUDIixXlHw2ewzDaus6UYuj+Vzz50Cn1R7tWqi5QN5UwcNdirKSfVO rFixHdC+xQ68d1V/IjTPaEUvpEtjwtaRXPlp2vc3ds2OnxuO7j9+NOpqlbnYwlGzNpt/OD CCcXapYW2f1kObiF1EtZBNyMegaIXRxVdmOZEks9EWow/1B5WvTXL0gBbJABYXJ4J4Y/M3 ktrliwyA12RJqtBRNzqhxWHer1XcEupZDDOzvQSlfihrt/NT4aXfx7Awi3Jt/Yl+BlD2DD PICVXbBn2hrk6RIrDspbkbgjjN9P9VQMRZOKn9ihSh2TAlTcSijy2jFA+nwNNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ts0bLZaI; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673876658; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=i0CpHHU+yfrGEMylEUzx9KIFo05gBP1TmZZVc7TUVyw=; b=LkvViUZwsRBB9PBrJCOtjvVIJP33ofv7InCt13qVWP5Yv2iIj1UEhe1sFQm2UzRTA7OaYu T9G6w+R9ux3knNBUxTUBcfEhLHefEg+9y+yiV7rO19QdGAvfS1Z7W+8pNOhBLAR4FQo1hd FxwSUTKgxBsMMNeWaL9mbvmjviV7DdRuQW9Q5/2FOXqqdBIdNxXa4mSxTOG7XNfzsCGv8T Elp0j+f6yZe9MfWLxaHGAvJjAB6OvDvRQ+6eg5kyNXXzmc77CnI1KkWhgKYlRPiPsoeBgY 7EKX4a+1khu3Bhc8QB+Oif24KMuh72UuEmsbYonBr3m/5WqCW/fhKDVAwZ4MoA== X-Migadu-Spam-Score: -6.07 X-Spam-Score: -6.07 X-Migadu-Queue-Id: C3524FDEF X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ts0bLZaI; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: APrIh7EEOZPe Tom Gillespie writes: > Small bugfix for emacs 25 compat. Best! > (format "babel-stable-%d" (random 1000)) > - (temporary-file-directory)))) > + temporary-file-directory))) Thanks! Note that Emacs 25 is no longer officially supported. AFAIR, some Org components are already failing in Emacs 25. However, the patch itself is reasonable because the return value of `temporary-file-directory' depends on `default-directory' - something we don't want to do for `defvar' statement. Could you please re-submit the patch altering the commit message stating the reason I stated? Also, Please quote Elisp symbols in the commit message as we usually do. See https://orgmode.org/worg/org-contribute.html#commit-messages -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at