From: Ihor Radchenko <yantar92@posteo.net>
To: Tom Gillespie <tgbugs@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] fix compat with emacs 25 due using temporary-file-directory
Date: Mon, 16 Jan 2023 13:44:14 +0000 [thread overview]
Message-ID: <87zgaik30x.fsf@localhost> (raw)
In-Reply-To: <CA+G3_PN-iWMxfMEFfnOT60tLow00c6_k++=OZyHVPwWvhOLQBQ@mail.gmail.com>
Tom Gillespie <tgbugs@gmail.com> writes:
> Small bugfix for emacs 25 compat. Best!
> (format "babel-stable-%d" (random 1000))
> - (temporary-file-directory))))
> + temporary-file-directory)))
Thanks!
Note that Emacs 25 is no longer officially supported. AFAIR, some Org
components are already failing in Emacs 25.
However, the patch itself is reasonable because the return value of
`temporary-file-directory' depends on `default-directory' - something we
don't want to do for `defvar' statement.
Could you please re-submit the patch altering the commit message stating
the reason I stated? Also, Please quote Elisp symbols in the commit
message as we usually do. See
https://orgmode.org/worg/org-contribute.html#commit-messages
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-01-16 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 5:29 [PATCH] fix compat with emacs 25 due using temporary-file-directory Tom Gillespie
2023-01-16 13:44 ` Ihor Radchenko [this message]
2023-01-20 14:13 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgaik30x.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=tgbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).