From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 6ObcF44xXmQutQAASxT56A (envelope-from ) for ; Fri, 12 May 2023 14:31:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wPnTF44xXmSlpgAAauVa8A (envelope-from ) for ; Fri, 12 May 2023 14:31:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 267ED3E370 for ; Fri, 12 May 2023 14:31:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxRub-0002Sg-US; Fri, 12 May 2023 08:30:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxRuI-0002Rc-BY for emacs-orgmode@gnu.org; Fri, 12 May 2023 08:30:00 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxRuB-0001vU-Ee for emacs-orgmode@gnu.org; Fri, 12 May 2023 08:29:53 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2AEFB24018B for ; Fri, 12 May 2023 14:29:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683894587; bh=NfWH1MoRpajC4+t4ODsTNOpUHVmQyIUMHIUhuD4f/aA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=SZ6+JavBDCp0xaK3eDd0R4ROD/zEllB2ib/RBB6ff0FkUk6hDQDYm+G197h1Gv/DR wIOW4oXuBfnTBbqagxjeU4bIGlTxdbG0ZWwMMT3pjnuxrkSj35GK//LkRQWcCUnkN2 P8lVuBMJfRan5LY/D/qK+0V9zVuVubj99YC11NG1PjLAiEei4nr1tFxgwkAEg93y1k 8mjas1/Zu/sgcQn6iXa0FEKpe1u1XjB7b/wiCcW6P0vPWqsaeSzSlcRwBa4ceWuht7 ezx4bJ3ckx/NvdrQAXjZ0why1zJfPcVysMBIS9/SmFEH90/BEDOz3ET6rG8ayjsmvU rj3+8v7Xk+dZQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QHp473t6Gz9rxk; Fri, 12 May 2023 14:29:43 +0200 (CEST) From: Ihor Radchenko To: Mehmet Tekman Cc: emacs-orgmode@gnu.org Subject: Re: [ANN] lisp/ob-tangle-sync.el In-Reply-To: <87r0ro9mzc.fsf@gmail.com> References: <87r0rxabd4.fsf@localhost> <87sfcd78vw.fsf@gmail.com> <87r0rxv3t5.fsf@localhost> <87lei577g4.fsf@gmail.com> <87lei5v1fg.fsf@localhost> <87fs8duyae.fsf@localhost> <8735451u20.fsf@gmail.com> <874jokbjsk.fsf@localhost> <87zg6ch2dm.fsf@gmail.com> <87sfc4a0ce.fsf@localhost> <87r0ro9mzc.fsf@gmail.com> Date: Fri, 12 May 2023 12:33:10 +0000 Message-ID: <87zg69zq49.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683894670; a=rsa-sha256; cv=none; b=ZpdaA5OEXWW7ulveByOIUMiknCrdTcKbdbDbrlWC+uoOs+73WD2aLcLJs121UEYzyr/I2l nvfZ5jmLO5ImBvoQ4Gi6p1x1ofJZBxDYWGDzGVJFLWuxnJZT3qagD1KaoX5AdrkqHezXL3 FS0lD3S8vsMUWSKHpXonrpqS0lXLQSdmxnRg+NJS1Q2k6YfXunBdABOJrdifBOheE94+E/ ro0vRY/I+mCLF+2TlMgjTXFI75RzBr5ybZsl4YIEaqplW2MQvZfqImk7FufbgCM/0uNzS3 rC4oAgQcposB31N7bQzz0Dc3ChxGo9FdHmNXnrNX/svmb4ep5312xdT3ANSLpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SZ6+JavB; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683894670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UEq+6jOgp+bq/ntNaTpYt2FphlpqDyJYk/ThDz6bfUs=; b=qGk5344x9JPL29eIGwibUSU9wCQMUNuXFSoc4ymNHSPqTkRh+frwGubaylpUejID0LfI33 Uxw0SvGLJFMUj5i/kxCvKfsePHOYt5bgFB04zNQmoxL4KspOneR2JvTLnDcnrOKGDRl5MR YDEfZgi85bWZbhc1aT5+P4iha29mlx18qvqpShtZRaNJ9ENHsfIcFP1Q/16WxwNSS72nPu CcbOVOhv2lggHNWN8spKAIt/6+iGJJCecEi7gO17/qdlSKPbTD+AK5GLLOKPKacfMDn7AN AGiaG2FEWZcSHDbMvnGCAv+QZ7xDoLqOlQdaSOilc9dDgiyEuwXvs8N3RLjwVw== X-Migadu-Spam-Score: -10.96 X-Spam-Score: -10.96 X-Migadu-Queue-Id: 267ED3E370 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=SZ6+JavB; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-TUID: 7q96mf6EFrju Mehmet Tekman writes: >> It will be great if you could do it. >> I have other things to work on. > > Of course! I'm just a little unfamiliar on how one coordinates active > collaboration via mailing list :-) Usually, we leave working on the patches to one person - whoever is the most interested in the patch. Maintainers and other interested users provide comments and suggestions. > I've modified the `merge' function within `org-babel-merge-params' so > that the main logic now accumulates a list of potential candidates that > could be the :any keyword, and selects the last added candidate as the > match. I feel confused when reading the modified code. > It all seems to be passing tests, though I would like to add my toy.org > file to the org testing framework at some point. I recommend trying various edge cases with your patch. In particular: 1. Testing exclusive group inheritance when we inherit a header arg value that matches :any: #+PROPERTIES: header-args :tangle "foo.txt" #+begin_src ... :tangle no #+PROPERTIES: header-args :tangle no #+begin_src ... :tangle "foo.txt" #+PROPERTIES: header-args :tangle no * Heading :PROPERTIES: :header-args: :tangle "foo.txt" :END: #+begin_src ... :tangle yes 2. :tangle "file with spaces.txt" I feel that the following code is not reliable when we inherit exact and :any exclusive group members in alternations. > + (if (member new-param exclusive-group) > ... > + ;; Cancel any potential matches if it's caught > + matched-param t > + potential-any-param nil) > + ;; If not a direct match, flag it as a potential > + ;; :any match This can happen multiple times for > + ;; each new-param, but only once for each > + ;; exclusive-group. > + (if (and (not matched-param) > + (member ":any" exclusive-group)) -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at