From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id AHHjGSGtwmT/zgAASxT56A (envelope-from ) for ; Thu, 27 Jul 2023 19:45:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eEbSGSGtwmT1PQAA9RJhRA (envelope-from ) for ; Thu, 27 Jul 2023 19:45:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D77344B0E2 for ; Thu, 27 Jul 2023 19:45:04 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=ericabrahamsen.net header.s=mail header.b="IsvE/UBV"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=ericabrahamsen.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690479905; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=T7XGUtXRmiEZ4gSSeV6vlLcweNkGcPzsXWIQrHV6Dy4=; b=LF/MN11YWruXfXDROcYj9MdAKcL+ulifb+wI9MJf+2fE8UxKOD43VLMPXcOBnsJ6hQWQii C/3jUnzVEz04I36icz5W7w8x3ITGmfjkajiJvUkcSRz3sZ/Db8ePmNcJsFpRJeU7GEzyww zdW+bPTWxry11ntUv0EfipNHuB9+8962AMgM4pd+n3jvApTwAYh5uipVzpLO6xWLS8fdc/ X+SIYprmlzXfAIqyxHSW69p+mF+bVg7LPS+qHvAl5aCc8X7doH837Ruw2kyKcDWfpfVpRU pXus4xHnHBjMrRxa53FCz7J6YZ0SeAf62BF5VG6ZXa9cqBFOfbWKlFPoMPwg9g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690479905; a=rsa-sha256; cv=none; b=qvXpgVn+XpkWIF8yj2JO4l7fEzGwXxiJWxoWzBb7ZS9emBEebSV8uFBHySPTLnGQdr9FgJ yZuGOXgFdJcA7cmjs28t91grNaKjneLJdTFalmkax8w1CM9YUF/r01p5cK85DrtvWOBTJ2 ai61er/na8XHtBSOC62l/if6Zd+2jxZ0A82TvFoZ1blQioPYY9oy3AsXykCKp6QrJbR/mN 7Oo2zuv3JqJHkuwnsINnkhDTeauKhOX+vOasZwDu3S5FgWPguVHhHcmSDm8TQuAL2qfqSX kiFYT1i9z1e7dVx6mD1+Qr5gTGf1IrbPAI4U643749uJCEI9WkDBgvApOGWRXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=ericabrahamsen.net header.s=mail header.b="IsvE/UBV"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=ericabrahamsen.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qP3Za-0008M1-E5; Thu, 27 Jul 2023 12:10:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qP3ZY-0008LF-97 for emacs-orgmode@gnu.org; Thu, 27 Jul 2023 12:10:40 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qP3ZW-0003R8-3w for emacs-orgmode@gnu.org; Thu, 27 Jul 2023 12:10:39 -0400 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 2BB3CFA0C3; Thu, 27 Jul 2023 16:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1690474228; bh=T7XGUtXRmiEZ4gSSeV6vlLcweNkGcPzsXWIQrHV6Dy4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IsvE/UBVqxjEkO9fgOEL819+Us72J6XKdBw0dKREzqdNuiAg/5mE6WZyyyOEECuPL nSTQyAhp/ZeUmYNrHTp0vJOipO+n3N36dalRvrJtR7OaG0BCUvEGMpVXNlSTEguti1 c5WBaoxKFlXsR++WHCmkSfseTZffV04jK76YFJe0= From: Eric Abrahamsen To: Jens Schmidt Cc: Ihor Radchenko , emacs-orgmode@gnu.org Subject: Re: [BUG] Issues in ol-gnus when storing links in nnvirtual and nnselect articles [9.7-pre (release_9.6.7-570-gd6f3ae.dirty @ /home/jschmidt/work/org-mode/lisp/)] In-Reply-To: <6aa47402-1546-272b-2859-4cfed1ea9ceb@vodafonemail.de> (Jens Schmidt's message of "Mon, 24 Jul 2023 22:23:59 +0200") References: <2fa5914d-2cbf-f41f-8be6-e79e77794140@vodafonemail.de> <87y1j8rrag.fsf@localhost> <1b9fbe38-0572-7861-e433-8f26457302bb@vodafonemail.de> <6aa47402-1546-272b-2859-4cfed1ea9ceb@vodafonemail.de> Date: Thu, 27 Jul 2023 09:10:17 -0700 Message-ID: <87zg3h49p2.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -5.91 X-Spam-Score: -5.91 X-Migadu-Queue-Id: D77344B0E2 X-Migadu-Scanner: mx1.migadu.com X-TUID: 2OK0eKjjV9NZ Jens Schmidt writes: > Uh, I had technical issues and did not get all mails as I expected. > Cobbling things together in one big reply now, with references and > quotes hopelessly broken ... hope you can sort it out. > > Anyway, thanks to Eric for chiming in. > >> Ideally, it would be nice to have tests, though I have no clue how to >> approach writing them. > > I have created a somewhat minimal Gnus setup to develop and test this > patch on my development laptop, where I normally do not use Gnus. It > consists of a bunch of files and directories and a bit of configuration. > I can follow up on this if you like, but preferably in a separate > thread. Someone mentioned gnus-mock in the other thread, which I made for exactly these scenarios. It's a bit hairy making a Gnus installation from nothing -- if you try it out and would like it to do something different, I'd be interested in feedback. >>> If we're currently in article-mode. The call to >>> `gnus-article-show-summary' would protect against the case where the >>> summary buffer has been killed in the meantime [...]. > > Not really. The following executed in an article buffer: > > (progn > (kill-buffer gnus-summary-buffer) > (gnus-article-show-summary)) > > results in > > Debugger entered--Lisp error: > (error "There is no summary buffer for this article buffer") > signal(error ("There is no summary buffer for this article buffer")) > error("There is no summary buffer for this article buffer") > gnus-article-show-summary() > [...] > > Which, OTOH, shows that I was wrong in one aspect: Gnus at least in some > cases *does* give a reasonable error message when the summary buffer for > an article buffer is gone. > >>> Probably it would be enough to wrap the whole containing `let*' in a >>> (with-current-buffer gnus-summary-buffer ...). If we're already in the >>> summary buffer, no harm done. >> >> I am not sure if it is safe. >> There is >> (save-window-excursion (gnus-summary-select-article)) >> which calls (set-buffer gnus-summary-buffer) > > I agree with Ihor here and would rather go for individual wraps into > `with-current-buffer'. As I have done in my patch already, > incidentially. Somehow I missed that this whole thread started with an actual patch! Sorry, that should have been the subject of discussion the whole time. I can help with applying it, once all issues are resolved. Thanks, Eric