From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id kJyaC8Zo6GQOMQEASxT56A (envelope-from ) for ; Fri, 25 Aug 2023 10:39:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wLpqC8Zo6GTKZgEAauVa8A (envelope-from ) for ; Fri, 25 Aug 2023 10:39:34 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D12F36AB4C for ; Fri, 25 Aug 2023 10:39:33 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=R1NV1+kp; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692952773; a=rsa-sha256; cv=none; b=WBgvJQ59YoO8OJli8uxJMaWXZth1ANodSZxyIUktsCNR+WZLQbFUym9WNwN68EGFdhikoR aXnNvE4MtdHg27eiUgYEsvTmqNSzc7u8URCVNnYv61OOo5yjCVUoCRKCP5zeGXZSHrcAht w5GPba9nz1mqcp60uaUJlAkDRRZwjFCRjTFJByyXFSjN8mN2/TmNpV8SDpL5JH7b2cdYKe 4IHZGQCz0+IC/I1HQiCmVggXlR+M7B/JXvHhaXq2gzBlQvpVavcqFoEcLxxmp6uOvWQjxU zB1H+lGJ/0fUW0lPfkb17X5oI8umegAUpwYBq0LnVQZSE1jWIvZCvBt/vqcUow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=R1NV1+kp; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692952773; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=u2zRxGOnoFDepq46XS6bRFGsrxW9eo4IDobHJrz+I/E=; b=LmvdJW4oDykwJmqFvvqHZkM+6/FAFxvBnSS9zWaZ5Uzjgl4hiWnSM7L/EuYHSdfVCzer4T SUnDn64muDzuP3AgIM7Lh2nf8jB8j9h4iwuRA+Fp3h9+oBPXidO2sfuOsFrf4hTyYDFR11 qHZ9ddXtfT6bB/XKxI1P9wrKgbe/d5VR6qJQaifEcvqNb/vVSegupkppizT//5KOlBDC/7 6FekK0zTWXc3XogEXLYRrUKWznP5UPe0P/QC6oKs+ti8z+2LppKUDGSHK6RUEcysvJvDF2 8sjczQIj/QdF3rRvvvptKrSVMUq/9QET+Ib7dGqe3sQX2HTcoiorkB8zxugtKQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZSLC-0007n6-Uv; Fri, 25 Aug 2023 04:38:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZSLB-0007mt-WE for emacs-orgmode@gnu.org; Fri, 25 Aug 2023 04:38:50 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZSL8-00016x-Tx for emacs-orgmode@gnu.org; Fri, 25 Aug 2023 04:38:49 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E67EB240101 for ; Fri, 25 Aug 2023 10:38:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692952724; bh=5zyKqPQmBMI1hGNTk2ABz2WaC3H+mSws49pMpDMmDVY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=R1NV1+kp/HfmuQ3v39XrfLtmuHbTa82pFbOGwC34yMNWtpbG5+lhFBwFIFBmnPHy8 c1667QwbPMLxmdaDnO7TtdHYG80VGA85KD8Myfmep3csF0tR+owOiBj/vZHkm0Rh7W 0h2jbI3ezxS4q4QYd85e5xHpdMqVX1Jor5KcIQg9X4LamcEYrNktW0X7rQMwr1o/hz DlvSwWp7g0JesoMY/rKQyt4EerZ6QdOTvyq896cs9INTtTNeU1v0e/XMlxfj++XJon PouF5jqKHV5UDJGiueOz3gnXMGfDFoCiqTBTdoCLe/0fswqomzp4eY0CG6X90mA0QE ZhmX/8DkpXsbg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RXCz816Pdz6txN; Fri, 25 Aug 2023 10:38:43 +0200 (CEST) From: Ihor Radchenko To: Margaret Patterson Cc: emacs-orgmode@gnu.org Subject: Re: [BUG] org-cite-insert fails to open json format bibliographies that contain entries for books with editors but no authors [9.6.6 (release_9.6.6 @ /snap/emacs/current/usr/share/emacs/29.1/lisp/org/)] In-Reply-To: References: Date: Fri, 25 Aug 2023 08:39:14 +0000 Message-ID: <87zg2fh5xp.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Spam-Score: -9.41 X-Migadu-Queue-Id: D12F36AB4C X-Migadu-Spam-Score: -9.41 X-TUID: Bj59pEPV0OZL --=-=-= Content-Type: text/plain Margaret Patterson writes: > Since upgrading to emacs 29.1 org-cite-insert no longer copes with > bibliography files in json format where there is an entry for a book > that has only editors and no author. Thanks for reporting! Does the attached patch fix the problem? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-lisp-oc-basic.el-Fix-parsing-editor-field-in-json-bi.patch >From 9ca03cfb827b5691665b472f3c7086a1c033ce0a Mon Sep 17 00:00:00 2001 Message-ID: <9ca03cfb827b5691665b472f3c7086a1c033ce0a.1692952720.git.yantar92@posteo.net> From: Ihor Radchenko Date: Fri, 25 Aug 2023 11:37:59 +0300 Subject: [PATCH] * lisp/oc-basic.el: Fix parsing "editor" field in json bibliographies (org-cite-basic--parse-json): Parse "editor" field, not "editors". "editors" is a typo - the common field name is "editor". For example, see https://www.bibtex.com/e/book-entry/. --- lisp/oc-basic.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el index c4468e5a8..2b78d85d0 100644 --- a/lisp/oc-basic.el +++ b/lisp/oc-basic.el @@ -162,7 +162,7 @@ (defun org-cite-basic--parse-json () (puthash (cdr (assq 'id item)) (mapcar (pcase-lambda (`(,field . ,value)) (pcase field - ((or 'author 'editors) + ((or 'author 'editor) ;; Author and editors are arrays of ;; objects, each of them designing a ;; person. These objects may contain -- 2.41.0 --=-=-= Content-Type: text/plain -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at --=-=-=--