emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>, Visuwesh <visuweshm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Add repeat-map for navigation commands
Date: Mon, 09 Sep 2024 18:36:50 -0700	[thread overview]
Message-ID: <87zfogxpal.fsf@gmail.com> (raw)
In-Reply-To: <8734m8rcoh.fsf@localhost>

>> From 8b980efcd9497e395f4d82a1304267ae4426b00d Mon Sep 17 00:00:00 2001
>> From: Visuwesh <visuweshm@gmail.com>
>> Date: Mon, 9 Sep 2024 19:46:47 +0530
>> Subject: [PATCH] Add repeat-mode keymap for navigation commands
>>
>> * org-keys.el (org-navigation-repeat-map): Add repeat-map to make
>> navigation easier when repeat-mode is turned on.
>
> May you also add a news entry?
> Ideally, we should also document this in the manual.

Do you think it makes sense to add repeat-maps for other next/previous
commands in Org, such as org-next-link and org-previous-link?  I've been
using this for a while (they don't use defvar-keymap as I wrote them a
while ago):

(defvar org-link-navigation-repeat-map
  (let ((map (make-sparse-keymap)))
    (define-key map (kbd "n") #'org-next-link)
    (define-key map (kbd "p") #'org-previous-link)
    (define-key map (kbd "v") #'org-link-preview) ;toggle preview for link at point
    map))

(map-keymap
 (lambda (_ cmd)
   (put cmd 'repeat-map 'org-link-navigation-repeat-map))
 org-link-navigation-repeat-map)

(defvar org-block-navigation-repeat-map
  (let ((map (make-sparse-keymap)))
    (define-key map (kbd "f") #'org-next-block)
    (define-key map (kbd "b") #'org-previous-block)
    map))

(put 'org-next-block     'repeat-map 'org-block-navigation-repeat-map)
(put 'org-previous-block 'repeat-map 'org-block-navigation-repeat-map)


  reply	other threads:[~2024-09-10  1:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 14:21 [PATCH] Add repeat-map for navigation commands Visuwesh
2024-09-09 16:53 ` Ihor Radchenko
2024-09-10  1:36   ` Karthik Chikmagalur [this message]
2024-09-15 12:54     ` Ihor Radchenko
2024-09-10  5:11   ` Visuwesh
2024-09-15 13:08     ` Ihor Radchenko
2024-09-16 12:29       ` Visuwesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfogxpal.fsf@gmail.com \
    --to=karthikchikmagalur@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=visuweshm@gmail.com \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).