[BUG] Image width specifications like :width 300px not working

[BUG] Image width specifications like :width 300px not working

[Karthik Chikmagalur]

Due to the change in 50be048ad0cbe0e9150ca2351b894b041ae7cf49, image
display specifications like 

#+attr_org: 300px

don't work.  From the commit message, it looks like the intent was to
ignore specifications like :width 4in.  I'm not sure if ignoring "px"
specifications was intentional.

If this is not a bug and width should be specified as an integer
(i.e. 300 instead of 300px), then the manual needs to be updated.
In (info "(org) Images") I still see examples like

          #+ATTR_HTML: :width 300px

-Karthik

Re: [BUG] Image width specifications like :width 300px not working

[Karthik Chikmagalur]

> Due to the change in 50be048ad0cbe0e9150ca2351b894b041ae7cf49, image
> display specifications like 
>
> #+attr_org: 300px
>
> don't work.  From the commit message, it looks like the intent was to
> ignore specifications like :width 4in.  I'm not sure if ignoring "px"
> specifications was intentional.

Note: If this is indeed a bug I can fix it as part of the WIP patch for
org-link-preview.

https://list.orgmode.org/orgmode/875xrqg6cb.fsf@gmail.com/

Re: [BUG] Image width specifications like :width 300px not working

[Ihor Radchenko]

Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:

> Due to the change in 50be048ad0cbe0e9150ca2351b894b041ae7cf49, image
> display specifications like 
>
> #+attr_org: 300px
>
> don't work.  From the commit message, it looks like the intent was to
> ignore specifications like :width 4in.  I'm not sure if ignoring "px"
> specifications was intentional.
>
> If this is not a bug and width should be specified as an integer
> (i.e. 300 instead of 300px), then the manual needs to be updated.
> In (info "(org) Images") I still see examples like
>
>           #+ATTR_HTML: :width 300px

I agree that it is a regression from the existing behavior.
(just as trating 4in and pixels was a regression from earlier behavior)

Probably, we can extend the regexp to treat things like px/pt as pixel
width as well.

I suggest doing it in a separate patch rather than making many changes
together with introducing a new feature as you suggested. Having too
many things in a single commit can lead to confusion. 

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Image width specifications like :width 300px not working

[Karthik Chikmagalur]

> Probably, we can extend the regexp to treat things like px/pt as pixel
> width as well.
>
> I suggest doing it in a separate patch rather than making many changes
> together with introducing a new feature as you suggested. Having too
> many things in a single commit can lead to confusion. 

Okay.  I'll send a patch to accommodate px and pt specifications after
merging the org-link-preview patch.  The relevant function was moved
into a different file so it's easier to do it in this order.

Karthik