[BUG] org-babel-header-arg-expand is rather cavalier about "appropriate context" [9.8-pre (release_9.7.10-127-g07dd3b @ /usr/local/share/emacs/site-lisp/org/)]

[Nick Dokos <ndokos@gmail.com>]

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
This was reported by user @Addlai on Emacs SE. See
https://emacs.stackexchange.com/questions/82276/stop-org-cycle-from-prompting-for-header-args

`org-babel-header-arg-expand' is added to the hook
`org-cycle-tab-first-hook' so when a TAB is pressed, the function is
called to check whether the context is approrpiate to call
`org-babel-enter-header-arg-w-completion'.

But the only thing it checks is whether the preceding character is a
colon and whether we are in a source block (by calling
`org-babel-where-is src-block-head'), so if one presses TAB inside a
python source block after a colon, the context is deemed "appropriate"
and you are asked for a header arg.

It should probably check that it's *on* the header line of the source
block, not just that it is *inside* the header block.

Emacs  : GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0)
 of 2024-08-09
Package: Org mode version 9.8-pre (release_9.7.10-127-g07dd3b @ /usr/local/share/emacs/site-lisp/org/)

-- 
Nick