From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8O9WHn3gH2fOrAAAe85BDQ:P1 (envelope-from ) for ; Mon, 28 Oct 2024 19:05:33 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8O9WHn3gH2fOrAAAe85BDQ (envelope-from ) for ; Mon, 28 Oct 2024 20:05:33 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IxA8oxAI; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730142333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ISsVccqdY1IT9RgQHseueoEN4xokY0GtjSdIZB3PgNA=; b=qWhy2SIOyDuiaFzm9t01Hfls1sfHud3XsLyE+NKRcUasbuvAQts0FNhAREYFUd+Awi4OAk w0wJZFj1zV61H0nb+dCTyekSM5s5djsPdDZl6WgUVSplFWlX8kJUYeUlBC97ES5nTfC3TH hYoawzLADLJOVDoq4W1INJSPLW0d/IjlbRzF6v21yjGfC9Mhz1mx9VDzP7qq69KA1nMz7o LCaGReB+qgA1r3fYZP21fjePC1FWPsJq5ecoOPhcLuFbVgtP80JOS0YGnZjLuHVZu34qrA +qWp3PDZC5WhtTCq7GZGi4EyIQgwVHkqlHdat2Wjhk6lcJB1hiPGL7S6IL53WA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730142333; a=rsa-sha256; cv=none; b=Uxs0IjiiB870Mt9kOzpfnIXak/e8d4GEChJFw7HOaFTC3BWPKHEgnyzDYFCTBgrzK8ZmLK oHvvn2yakuMytqEoImdvOsnTAJMKfkovU4djH/LA4moeCV8lQ22lxX2394rspJnn3Pgm1R SKRr6H4pRlESE+wUVxoUpFcHAfdbb/wo3V+bRu3900I9vTWlcUqijGKt/I8C+2mNgSanpv Lssq8mrS9aP2EZmqDuPIE13hzKLtBLu2yQgmu3VrnuySyc1QPwqikYOeEi9FM9FUl2+RXu eapQfeKprq4j2l4l9GoaIDvpXwyt6kx1/KC3+CRf9yLfXnu/PtMaCsQOD8Mo5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=IxA8oxAI; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F0AD150694 for ; Mon, 28 Oct 2024 20:05:32 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5V2X-0001ww-0T; Mon, 28 Oct 2024 15:04:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5V2U-0001wY-7H for emacs-orgmode@gnu.org; Mon, 28 Oct 2024 15:04:30 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5V2Q-00082p-Hn for emacs-orgmode@gnu.org; Mon, 28 Oct 2024 15:04:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D2FA0240027 for ; Mon, 28 Oct 2024 20:04:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1730142263; bh=zPfGZs66OcmA+CuA2VYGESYMSZTrKlsKIjaW/cLpjiU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=IxA8oxAI8f1nbijTYVe0ovWTu2KqBbwOWm5voBjLduLRbVV5o/DksyUQWIljz5ALp snW/CR4gT98ugWlawM7xI0GJgTrV+43TAi782bqSsfWU4tuvB6WEapTX6iMBhp7Ymz Lk8D8YjiZ6ro/JN32qD8hjP2tqqu99/FG87W272htUmkp+hHmza5fvrl5RqZtr7zEz fem9pZq7QBY/Pdn5qOlJD4ki3xrW4NROz/Elih+QSCcjNL4MmzMCQKYF51D1uxFKqN z8e803WtcjNjhZ4VYpyCqla7VRazA3osS4jRRlBbjiaPcJCV6oxW0TmMRIrPDuKo1v QAYhMSpOjFl2w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4XcjVZ52q9z9rxK; Mon, 28 Oct 2024 20:04:22 +0100 (CET) From: Ihor Radchenko To: Jonas Bernoulli Cc: 8dcc <8dcc.git@gmail.com>, emacs-orgmode@gnu.org Subject: Re: [BUG] Texinfo: Commas in URL text are not escaped In-Reply-To: <87iktd9nzj.fsf@bernoul.li> References: <87set58skp.fsf@gmail.com> <87ed4cwkzm.fsf@localhost> <87iktd9nzj.fsf@bernoul.li> Date: Mon, 28 Oct 2024 19:06:07 +0000 Message-ID: <87zfmojbds.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -4.31 X-Spam-Score: -4.31 X-Migadu-Queue-Id: F0AD150694 X-Migadu-Scanner: mx13.migadu.com X-TUID: OxZaYQXRBjZd Jonas Bernoulli writes: >> * lisp/ox-texinfo.el (org-texinfo--sanitize-content): Sanitize commas >> everywhere to make sure that we do not end up with text commas being >> interpreted as argument separator in @command{arg1, arg2, ...}. This >> approach will produce @comma{} even when it is not necessary, but it >> is the safest approach. > > Could you please find a more localized solution? I would expect that > this can be done in org-texinfo-link instead. Replacing every comma > with @comma{} makes the resulting texinfo much harder to read. It indeed makes texinfo harder to read, but the original bug did not only reveal problems with @uref. At least, commands like @email (or anything else that can accept multiple arguments) are also bugged. Unfortunately, I am not very familiar with Texinfo (and ox-texinfo does not have a dedicated maintainer). So, given that comma appears to be special in various Texinfo constructs, I went with the safest option available. If someone who knows Texinfo syntax and how comma is used there can provide information on where exactly "," is special, it would help creating a clearner fix. For the time being, I judged that ugly texi sources are better than buggy export. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at