emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: 8dcc <8dcc.git@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [BUG] Texinfo: Commas in URL text are not escaped
Date: Mon, 28 Oct 2024 19:06:07 +0000	[thread overview]
Message-ID: <87zfmojbds.fsf@localhost> (raw)
In-Reply-To: <87iktd9nzj.fsf@bernoul.li>

Jonas Bernoulli <jonas@bernoul.li> writes:

>> * lisp/ox-texinfo.el (org-texinfo--sanitize-content): Sanitize commas
>> everywhere to make sure that we do not end up with text commas being
>> interpreted as argument separator in @command{arg1, arg2, ...}.  This
>> approach will produce @comma{} even when it is not necessary, but it
>> is the safest approach.
>
> Could you please find a more localized solution?  I would expect that
> this can be done in org-texinfo-link instead.  Replacing every comma
> with @comma{} makes the resulting texinfo much harder to read.

It indeed makes texinfo harder to read, but the original bug did not
only reveal problems with @uref. At least, commands like @email (or
anything else that can accept multiple arguments) are also bugged.

Unfortunately, I am not very familiar with Texinfo (and ox-texinfo does
not have a dedicated maintainer). So, given that comma appears to be
special in various Texinfo constructs, I went with the safest option
available.

If someone who knows Texinfo syntax and how comma is used there can
provide information on where exactly "," is special, it would help
creating a clearner fix.

For the time being, I judged that ugly texi sources are better than
buggy export.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


      reply	other threads:[~2024-10-28 19:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 10:43 [BUG] Texinfo: Commas in URL text are not escaped 8dcc
2024-10-19  8:33 ` Ihor Radchenko
2024-10-27 22:31   ` Jonas Bernoulli
2024-10-28 19:06     ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfmojbds.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=8dcc.git@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jonas@bernoul.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).