From: Ihor Radchenko <yantar92@posteo.net>
To: Jack Kamm <jackkamm@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix ox-icalendar export of diary timestamps
Date: Mon, 13 Jan 2025 17:19:46 +0000 [thread overview]
Message-ID: <87zfju7hsd.fsf@localhost> (raw)
In-Reply-To: <87h663pveq.fsf@gmail.com>
Jack Kamm <jackkamm@gmail.com> writes:
> Unfortunately I found a case in the wild where this change caused a
> temporary problem in org-caldav:
> https://github.com/dengste/org-caldav/issues/315
> ...
> I attach a patch to do this, by adding an option `active-exclude-diary'
> for `org-icalendar-with-timestamps' and `org-export-with-timestamps'.
Sounds reasonable.
> +To export active timestamps only without diary timestamps, users can
> +set ~org-export-with-timestamps~ and ~org-icalendar-with-timestamps~
> +to ~active-exclude-diary~.
Maybe you can emphasize more that "without diary timestamp" is the old
behavior. We often use "old behavior" when guiding users how to revert
newly added features that do not want.
Otherwise, LGTM.
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
prev parent reply other threads:[~2025-01-13 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 6:26 [PATCH] Fix ox-icalendar export of diary timestamps Jack Kamm
2024-09-21 8:53 ` Ihor Radchenko
2024-09-21 18:20 ` Jack Kamm
2024-09-22 10:25 ` Ihor Radchenko
2025-01-12 21:35 ` Jack Kamm
2025-01-13 17:19 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfju7hsd.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=jackkamm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).