emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bernt Hansen <bernt@norang.ca>
To: Carsten Dominik <carsten@orgmode.org>
Cc: Org Mode Mailing List <emacs-orgmode@gnu.org>
Subject: [PATCH] Allow more asterisks in tasks when summarizing clock time
Date: Wed, 27 Feb 2008 19:29:45 -0500	[thread overview]
Message-ID: <87y795exdy.fsf@gollum.intra.norang.ca> (raw)
In-Reply-To: <87y7960wnw.fsf@gollum.intra.norang.ca> (Bernt Hansen's message of "Wed\, 27 Feb 2008 19\:09\:07 -0500")


10 asterisks is only 6 levels deep when odd levels only are used.
This increases the number of asterisks to 40 (still an arbitrary number)
but it's much larger than the current limit of 10.

This fixes C-c C-x C-d when trying to summarize clock time on a
deeply nested task

,----[ test.org ]
| * Task1
| *** Task2
| ***** Task3
| ******* Task4
| ********* Task5
| *********** Task6
| 	    :CLOCK:
| 	    CLOCK: [2008-02-27 Wed 14:30]--[2008-02-27 Wed 14:44] =>  0:14
| 	    :END:
`----
---

This patch works for me.  You can apply this patch directly in git by
saving this message in mbox format (e.g. file.mbox) and then doing 

$ git am file.mbox

This will create the commit on the current HEAD with all of the provided
commit message text.

The text between the three dashes (---) above and the start of the
diffstat below (org.el |    2 +-) is discarded which is why I'm writing
my extra notes here :)

HTH,
-Bernt


 org.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/org.el b/org.el
index 0c2762d..504dcd5 100644
--- a/org.el
+++ b/org.el
@@ -18919,7 +18919,7 @@ will be easy to remove."
 		     (make-string (+ off (max 0 (- c (current-column)))) ?.)
 		     (org-add-props (format "%s %2d:%02d%s"
 					    (make-string l ?*) h m
-					    (make-string (- 10 l) ?\ ))
+					    (make-string (- 40 l) ?\ ))
 			 '(face secondary-selection))
 		     ""))
     (if (not (featurep 'xemacs))
-- 
1.5.4.3.192.g923d4

  reply	other threads:[~2008-02-28  0:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28  0:09 BUG: Clocking deeply nested tasks Bernt Hansen
2008-02-28  0:29 ` Bernt Hansen [this message]
2008-02-28  1:08   ` [PATCH] Allow more asterisks in tasks when summarizing clock time Bastien
2008-02-28  1:09     ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y795exdy.fsf@gollum.intra.norang.ca \
    --to=bernt@norang.ca \
    --cc=carsten@orgmode.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).