From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eric Schulte" <schulte.eric@gmail.com>
Subject: Re: org-plot histogram bug when the x-axis labels could be
 interpreted as numbers
Date: Wed, 14 Jan 2009 13:10:14 -0800
Message-ID: <87y6xd7fwp.fsf@gmail.com>
References: <41c818190901140849xf500eadye6b476dd7f2aad2e@mail.gmail.com>
	<ufxjlzlti.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LNCzj-0000d3-T5
	for emacs-orgmode@gnu.org; Wed, 14 Jan 2009 16:09:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LNCzi-0000bY-8S
	for emacs-orgmode@gnu.org; Wed, 14 Jan 2009 16:09:47 -0500
Received: from [199.232.76.173] (port=48902 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LNCzi-0000bR-1e
	for emacs-orgmode@gnu.org; Wed, 14 Jan 2009 16:09:46 -0500
Received: from rv-out-0708.google.com ([209.85.198.242]:25800)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <schulte.eric@gmail.com>) id 1LNCzh-0003dN-HN
	for emacs-orgmode@gnu.org; Wed, 14 Jan 2009 16:09:45 -0500
Received: by rv-out-0708.google.com with SMTP id k29so855777rvb.6
	for <emacs-orgmode@gnu.org>; Wed, 14 Jan 2009 13:09:44 -0800 (PST)
In-Reply-To: <ufxjlzlti.fsf@gmail.com> (Charles Sebold's message of "Wed, 14
	Jan 2009 14:15:05 -0600")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Charles Sebold <csebold@gmail.com> writes:

> On 14 Jan 2009, William Henney wrote:
>
>> From glancing through org-plot.el, it seems as though the problem is
>> that the text-ind parameter is false when all the values in the
>> "independent variable" column are legal numbers. However, my lisp
>> skills are not up to fixing this.
>
> This may fix that problem, but I don't know that it doesn't produce a
> nest of bigger ones.  Eric should look at this first.  This seems to me
> to be useful enough when producing histograms.
>

Hi,

I believe that forcing text-ind to be true when the plot type is 'hist'
is a safe enough maneuver (especially plotting with hist seems to fail
if text-ind is not true).

I would recommend this patch.  It's the same idea as Charles' only
implemented in a different place.

Thanks -- Eric

diff --git a/lisp/org-plot.el b/lisp/org-plot.el
index 7efd84a..1792d50 100644
--- a/lisp/org-plot.el
+++ b/lisp/org-plot.el
@@ -316,12 +316,13 @@ line directly before or after the table."
 			   (mapcar (lambda (row) (nth ind row)) table)))) 0)
 	      (plist-put params :timeind t)
 	    ;; check for text ind column
-	    (if (> (length
-		    (delq 0 (mapcar
-			     (lambda (el)
-			       (if (string-match org-table-number-regexp el)
-				   0 1))
-			     (mapcar (lambda (row) (nth ind row)) table)))) 0)
+	    (if (or (string= (plist-get params :with) "hist")
+		    (> (length
+			(delq 0 (mapcar
+				 (lambda (el)
+				   (if (string-match org-table-number-regexp el)
+				       0 1))
+				 (mapcar (lambda (row) (nth ind row)) table)))) 0))
 		(plist-put params :textind t)))))
       ;; write script
       (with-temp-buffer