From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: need detailed instructions for submitting the patch Date: Mon, 09 Aug 2010 20:55:57 -0400 Message-ID: <87y6cfb80y.fsf@gollum.intra.norang.ca> References: <872864733.20100810015957@gmail.com> <20100809233613.GA2414@soloJazz.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=51407 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oid8f-0003RF-LS for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 20:56:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oid8e-00085g-7X for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 20:56:21 -0400 Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:54659) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oid8e-000849-5u for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 20:56:20 -0400 In-Reply-To: <20100809233613.GA2414@soloJazz.com> (Juan's message of "Mon, 9 Aug 2010 20:36:13 -0300") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Juan Cc: emacs-orgmode@gnu.org, Ivanov Dmitry Juan writes: > On Tue, Aug 10, 2010 at 01:59:57AM +0400, Ivanov Dmitry wrote: >> The http://orgmode.org/worg/org-contribute.php#sec-3 says: >> "Git can be used to make patches and send them via email - this is >> perfectly fine for minor changes. These patches will be >> automatically registered at John Wiegley's patchwork server" >> >> Please, tell me, what commands should I run to create a patch, >> upload it and get any feedback from the senior developers? > > The following command will make a patch between the staging area > (in your computer), and the file you modified: > > git diff -p org-whatever.el > > If you already committed your changes to your index (staging area), > then you should compare against a particular branch (in this example, > origin/master): > > git diff -p origin/master org-whatever.el > > You email the output to this mailing list, adding [PATCH] to the > subject, and description of what you fixed or changed. > > At least, this is how I do it. > > Regards, > .j. It's easier to make real commits on a topic branch and use either git send-email or git format-patch to create the properly formatted patch files. I personally use git send-email --annotate -N (where N is the number of commits I want to create patches for. For example, git send-email --annotate -1 if it is a single commit) I have the following in my .git/config so that git send-email knows where to send the resulting patches ,----[ .git/config ] | [sendemail] | to = emacs-orgmode@gnu.org `---- Alternatively, git format-patch will create sequentially numbered files which you can edit and mail manually from your email client. HTH, Bernt