From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Eric Schulte" <schulte.eric@gmail.com>
Subject: Re: Re: [Babel] How to pass variables to SQL blocks?
Date: Mon, 13 Dec 2010 12:53:32 -0700
Message-ID: <87y67th2kj.fsf@gmail.com>
References: <80pqtoqfkh.fsf@missioncriticalit.com> <87ipzefcga.fsf@gmail.com>
	<80tyixlr0s.fsf@missioncriticalit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=42973 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PSESt-0004ep-49
	for emacs-orgmode@gnu.org; Mon, 13 Dec 2010 14:53:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PSESs-00063h-05
	for emacs-orgmode@gnu.org; Mon, 13 Dec 2010 14:53:43 -0500
Received: from mail-pv0-f169.google.com ([74.125.83.169]:45131)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <schulte.eric@gmail.com>) id 1PSESr-00063M-Ql
	for emacs-orgmode@gnu.org; Mon, 13 Dec 2010 14:53:41 -0500
Received: by pvc30 with SMTP id 30so1706107pvc.0
	for <emacs-orgmode@gnu.org>; Mon, 13 Dec 2010 11:53:40 -0800 (PST)
In-Reply-To: <80tyixlr0s.fsf@missioncriticalit.com> (=?utf-8?Q?=22S=C3=A9b?=
	=?utf-8?Q?astien?= Vauban"'s
	message of "Wed, 01 Dec 2010 11:35:31 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: =?utf-8?Q?S=C3=A9bastien?= Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org

S=C3=A9bastien Vauban <wxhgmqzgwmuf@spammotel.com> writes:

>
> (I thought this feature would be implemented using "real" SQL vars, hence=
 my @
> prefix. But viewing the code shows the replacement is made outside of the=
 SQL
> snippet's knowledge.)
>

I agree that using real SQL variables would be preferable.  If you want
to submit a patch to this effect I would be happy to review it and apply.

>
> Tested. Works as expected... Thanks a lot!
>
>
> Maybe the following should be put on some TODO list, even if not urgent?
>
>>> * No warning if block does not exist
>>>
>>> Please note that inexistent references are ignored, without further not=
ice.
>>> That's the case for such a block (where I forgot the number suffix):
>>>
>>> #+srcname: contains-inexistent-ref
>>> #+begin_src sql :noweb yes
>>> <<add-column-in-table>>
>>> #+end_src
>

The lack of notice (or error) was originally intentional.  The logic
being that there may be languages in which <<something>> constructs are
part of the language syntax, and in those languages Org-mode should
ignore such constructs unless the "something" contained in the <<>>'s is
actually the name of a code block.

It may make sense to revisit this design decision.

Best -- Eric

>
> Thanks.
>
> Best regards,
>   Seb