From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: Replaced obsolete interactive-p function
Date: Thu, 30 Jun 2011 10:36:17 +0200
Message-ID: <87y60jzpfi.fsf@gnu.org>
References: <87zkl01u4y.fsf@gnu.org>
	<877h845l18.wl%markert.michael@googlemail.com>
	<FED5AF96-20E9-46B2-945B-E0366E11212F@gmail.com>
	<87vcvojk09.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:41709)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1QcCj1-000404-2E
	for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 04:35:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1QcCiz-0005nj-N7
	for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 04:35:50 -0400
Received: from mail-wy0-f169.google.com ([74.125.82.169]:56385)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1QcCiz-0005nd-Aj
	for emacs-orgmode@gnu.org; Thu, 30 Jun 2011 04:35:49 -0400
Received: by wyg36 with SMTP id 36so1695500wyg.0
	for <emacs-orgmode@gnu.org>; Thu, 30 Jun 2011 01:35:48 -0700 (PDT)
In-Reply-To: <87vcvojk09.fsf@gmail.com> (Eric Schulte's message of "Wed, 29
	Jun 2011 16:27:17 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Eric Schulte <schulte.eric@gmail.com>
Cc: emacs-orgmode@gnu.org, Michael Markert <markert.michael@googlemail.com>, Carsten Dominik <carsten.dominik@gmail.com>

Hi Eric and Michael,

Eric Schulte <schulte.eric@gmail.com> writes:

> Michael's patch looks great to me, I can confirm that it does stifle the
> warnings on Emacs24, and everything compiles and works as expected -- at
> least as far as the Org-mode test suite is able to differentiate.

Thanks to Michael for the patch, it does indeed fix the warnings.

> In addition to applying this patch I've also added another patch which
> supplies the optional KIND argument to every invocation of
> org-called-interactively-p.

I thought the absence of argument was taken care by the
org-called-interactively-p macro -- see the (with-no-warning ...) 
sexp in it, and the comment.

Eric, any reason for explicitely adding an argument?

I understand it's better for readability and it will ease the future
replacement of org-called-interactively-p by called-interactively-p,
but I was just curious to know if there was some other reasons.

Thanks!

-- 
 Bastien