emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: Keeping an eye on byte-compilation warnings
Date: Sun, 14 Aug 2011 10:14:42 +0200	[thread overview]
Message-ID: <87y5ywif4d.fsf@Rainer.invalid> (raw)
In-Reply-To: m24o1lnfr5.fsf@gmail.com

John Wiegley <jwiegley@gmail.com> writes:
> Maybe we're all using different versions of Emacs, but I find that
> byte-compilation warnings keep increasing as time goes by.  I'd like to ask
> people to compile their code before committing, to keep the build log clean.
> It looks messy when there are lots of unnecessary warnings.

Thank you for bringing this up (again).  A few comments:

The function that calls org-agenda-todo probably belongs into
org-agenda.

The function org-copy-visible uses two function from org-exp.el, but
probably doesn't belong there, so a declaration of these two functions
would be needed.  I don't think autoloading during compile is
appropriate (does that even work?), and I'm not a huge fan of using
require in eval-when-compile for in-package functions (it's OK for
external dependencies).  In a nutshell, that only works correctly when
the dependencies between the lisp files are correctly defined or if the
byte-compiled files are always removed before starting a new
byte-compile.  Since there are quite a few circular dependencies
introduced by using require rather than declarations, only the latter
currently works (and hence the usual incantation of 'make clean && make
compile', which would not be necessary otherwise).

Can you recommend a package that can extract the dependencies and
perhaps highlight the circulars?  There is a page in EmacsWiki with some
libraries, but I haven't worked with them yet.  It seems like a good
idea to try and untangle that cicular dependencies mess...


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Blofeld:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

  parent reply	other threads:[~2011-08-14  8:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-13 21:49 Keeping an eye on byte-compilation warnings John Wiegley
2011-08-14  6:39 ` David Maus
2011-08-14  8:14 ` Achim Gratz [this message]
2011-08-15  7:46   ` Bastien
2011-08-14 18:25 ` Bastien
2011-08-15  7:46 ` Bastien
2011-08-18 18:08   ` Achim Gratz
2011-08-19 21:55     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5ywif4d.fsf@Rainer.invalid \
    --to=stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).