From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [BUG] Inconsistency in src block hiding Date: Thu, 19 Jan 2012 20:18:54 +0100 Message-ID: <87y5t34i1t.fsf@gmail.com> References: <8739djqfkv.fsf@gmail.com> <87fwhiwwr0.fsf@gmail.com> <87bos6pp1a.fsf@gmail.com> <8739dhnxjs.fsf@gmail.com> <87ipmcxboo.fsf@gmail.com> <87pqgjipu8.fsf@gmail.com> <87y5v6x3lv.fsf@gmail.com> <87fwh86533.fsf@gmail.com> <87ehwbdxk2.fsf@gnu.org> <874nx782wi.fsf@gmx.com> <87lip76p48.fsf@norang.ca> <87d3ai2p98.fsf@gmail.com> <8762ga6whl.fsf@norang.ca> <87pqehrnjv.fsf@gmx.com> <8739bc3ob5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:53395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnxXd-0002Q5-RW for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 14:20:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RnxXc-0005wK-Fe for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 14:20:57 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:52262) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnxXc-0005wG-7v for emacs-orgmode@gnu.org; Thu, 19 Jan 2012 14:20:56 -0500 Received: by wicr5 with SMTP id r5so322953wic.0 for ; Thu, 19 Jan 2012 11:20:55 -0800 (PST) In-Reply-To: (Martyn Jago's message of "Thu, 19 Jan 2012 12:10:26 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: emacs-orgmode@gnu.org Hello, Martyn Jago writes: > These changes /have/ caused a software regression, and should be > reverted immediately, since: > > - they change current expected and implemented behavior to the cost of > users expectations and current use, with no prior discussion and > agreement on behavior changes Surprisingly, I do remember discussing about this change not so long ago. Thus, I think the "no prior discussion" is fallacious. To sum it up, in that discussion, I had suggested that allowing to fold keywords wasn't a good idea since: 1. Every element could get a #+name keyword, so everything would be eventually foldable (and think about the mess to unfold piece-wise, or everything). 2. Drawers would have consequently no more purpose (properties drawer excepted). > It has been proven that to achieve the required consistency set out by > this thread /without/ breaking current expectations is less than > straight-forward, and the changes should therefore be moved to > EXPERIMENTAL - at least until the changes are proven not to break > current expectations. > > Much of org-mode is currently inconsistent - and while it is highly > desirable to improve on that situation, it should not become the major > decision to change code at the cost of regression - org-mode is a very > practical system used successfully by lots of (very appreciative) > people, and while all users appreciate bug fixes / enhancements in the > fast-moving repository that is org-mode (thanks Carsten), clear > regression such as this should be avoided in master at all costs. As a side note, master isn't maint, which is the place for stability and also bug fixing. On the other hand, if a change doesn't hit master branch, it won't get enough testing. Now, there is no regression here: it has never been specified that "#+results" keywords must allow to fold code. Folding is about headlines, blocks, drawers and, optionally, items. Period. Relying on "#+keyword" folding is a mistake. It would be better to improve and correct drawers export (one of the things I address in the new exporter). I talked in this thread about drawers rehabilitation. Reverting this change will postpone this goal or, worse, bury it. Regards, -- Nicolas Goaziou