From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: Problems with (defvar foo) and Emacs 23 Date: Sun, 01 Apr 2012 23:18:10 +0200 Message-ID: <87y5qfp2wd.fsf@Rainer.invalid> References: <87sjgngtzk.fsf@norang.ca> <87aa2vp5ri.fsf@Rainer.invalid> <87aa2vw5mq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:53241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SESAM-0002ZH-VR for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 17:18:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SESAK-0008AK-SK for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 17:18:26 -0400 Received: from plane.gmane.org ([80.91.229.3]:41299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SESAK-0008AD-Lz for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 17:18:24 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SESAH-0003Vo-NA for emacs-orgmode@gnu.org; Sun, 01 Apr 2012 23:18:21 +0200 Received: from pd9eb4736.dip.t-dialin.net ([217.235.71.54]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Apr 2012 23:18:21 +0200 Received: from Stromeko by pd9eb4736.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Apr 2012 23:18:21 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien writes: > Well -- I'll be pretty busy next week, so hopefully we can fix this > soon... any help welcome! :) Ditto, but you do realize this will be horribly broken in Emacs 24? Anyway, for that single dynamic "state" variable: it is let-bound in org.el/org-todo and then dynamically scoped in many, many places: contrib/lisp/{org-{checklist,choose},org2rem}.el /lisp/{org-{agenda,clock,icalendar,mouse,taskjuggler},org}.el So the correct prefixed name should probably be org-todo-state (there are other such "state"s in other places, don't know yet if they are also dynamically scoped into other functions). You need to also keep track of which functions use "state" as a formal parameter name, since these shadow the dynamic variable from the outside, but provide another "state" for calls on the inside… Haven't yet checked any of the other definitions that had their name changed, gotta fetch some sleep before work. HTH, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Factory and User Sound Singles for Waldorf rackAttack: http://Synth.Stromeko.net/Downloads.html#WaldorfSounds