Re: Patch: org-agenda-skip-deadline-prewarning-if-scheduled prior to scheduled date

[Justus-dev@Piater.name]

Nicolas,

Many thanks for your comments, I will heed them all.

But first one more request for comments that I forgot to include in my
original message:

Computing the difference between two dates in the presence of repeating
dates is a subtle affair.  Here, in computing the difference between
deadline (d2) and scheduled date (ds),

			(min (- d2 (org-time-string-to-absolute
				    ds d1 'past show-all (current-buffer) pos))
			     org-deadline-warning-days)

I simply followed the time-to-deadline computation of the current TODO
item from a few lines above:

	(setq ...
	      d2 (org-time-string-to-absolute
		  (match-string 1) d1 'past show-all
		  (current-buffer) pos)
	      diff (- d2 d1))

I sort-of see what this org-time-string-to-absolute call does, but I do
not fully understand its implications.  It would be good for someone who
does to verify that my code indeed rightly follows the same logic.

It appears to work for me with various repeating and non-repeating TODOs
with dates in past and future, but I certainly did not exhaustively test
all possible combinations of sensible and nonsensical combinations of
non/repeating scheduled and deadline dates, show-all, and so on.

Cheers,
Justus

-- 
Intelligent and Interactive Systems https://iis.uibk.ac.at/
Institute of Computer Science, University of Innsbruck, Austria