From mboxrd@z Thu Jan 1 00:00:00 1970 From: aaronecay@gmail.com Subject: Re: [PATCH] ox-latex: provide width and height options for images Date: Tue, 05 Mar 2013 23:02:05 -0500 Message-ID: <87y5e189c2.fsf@gmail.com> References: <87obf63mq6.fsf@gmail.com> <1361906554-26709-1-git-send-email-aaronecay@gmail.com> <87621etban.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([208.118.235.92]:54797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD5YO-00077i-Ln for emacs-orgmode@gnu.org; Tue, 05 Mar 2013 23:02:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UD5YN-0004h1-GT for emacs-orgmode@gnu.org; Tue, 05 Mar 2013 23:02:08 -0500 Received: from mail-qe0-f51.google.com ([209.85.128.51]:54762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UD5YN-0004gx-CW for emacs-orgmode@gnu.org; Tue, 05 Mar 2013 23:02:07 -0500 Received: by mail-qe0-f51.google.com with SMTP id nd7so5167700qeb.10 for ; Tue, 05 Mar 2013 20:02:06 -0800 (PST) In-Reply-To: <87621etban.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org 2013ko otsailak 27an, Nicolas Goaziou-ek idatzi zuen: > Thank you for your patch. Here are a few comments. Thank you for the comments! I think the patch is simpler and better thanks to them. >=20 >> These are implemented with \resizebox, and thus are uniform across >> different types of image inclusion (\includegraphics, \input of tikz >> images). This differs from the older way of using width and height >> optional args to \includegraphics. >=20 > I tend to agree with Rasmus. It would be better to keep height and > width options in \includegraphics when possible. Okay. >=20 >> Thus, the default value for org-latex-image-default-options is left >> untouched, to avoid breaking compatibility with older code. After a >> transition period, the 0.9\linewidth value should be moved into >> org-latex-image-default-width, and the -options variable set to the >> empty string. >=20 > We don't need this precaution. The exporter code for 8.0 introduced > many incompatibilities already. Also, this one is easy to discover. Okay. >=20 > I think it's a good step forward. It will need to be documented in the > comments at the beginning of ox-latex.el, where all attributes > properties relative to different syntactical elements are explained. Okay =E2=80=93 see what you think of the documentation in the new patch. >=20 > Here, you can obtain \resizebox{!}{!}{%s}, which is wrong, isn't it? No...it is a no-op. That said, the code should no longer do this. >=20 > This needs to be changed as these options would interfere with :width > argument. For example, (eq float 'float) could set :width property if > it is undefined. Obviously, this means the check has to be done before > WIDTH and HEIGHT strings are built. This should now be handled. The new patch will follow this email. In related news, I have completed the FSF copyright assignment process, so the patch can be merged whenever it is deemed ready. Thanks again, --=20 Aaron Ecay