From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Add a flat clocktable formatter useful for tables whose CSV export can be imported into accounting/invoiving tools such as Zoho Invoicing. Date: Sun, 30 Jun 2013 22:25:56 +0200 Message-ID: <87y59rrzsi.fsf@bzg.ath.cx> References: <874nci7tob.fsf@rpatterson.net> <871u7mn2dm.fsf@bzg.ath.cx> <87vc4x3by1.fsf@rpatterson.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtQF2-0001CX-FF for emacs-orgmode@gnu.org; Sun, 30 Jun 2013 18:37:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtQF1-0006YQ-6j for emacs-orgmode@gnu.org; Sun, 30 Jun 2013 18:37:08 -0400 Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:37792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtQF1-0006XJ-0z for emacs-orgmode@gnu.org; Sun, 30 Jun 2013 18:37:07 -0400 Received: by mail-we0-f173.google.com with SMTP id x54so2746174wes.4 for ; Sun, 30 Jun 2013 15:37:05 -0700 (PDT) In-Reply-To: <87vc4x3by1.fsf@rpatterson.net> (Ross Patterson's message of "Fri, 28 Jun 2013 19:09:10 -0700") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ross Patterson Cc: emacs-orgmode@gnu.org Hi Ross, Ross Patterson writes: > Bastien writes: > >> thanks for the patch. Do you mind filling the copyright >> assignment so we can accept the patch ? > > I already have an FSF Emacs Assignment from 2008-12-22, RT 393650. Is > there something else I need to do? Nope. I didn't know you had a FSF assignment. That said, the patch looks more like an add-on to Org for a very specific use, so putting this code in contrib/ would be better. Also, `org-clock-clocktable-flat-columns' defines some customizable values that are hardcoded in `org-clocktable-write-flat'. Either the values should not be customizable, or the `org-clocktable-write-flat' should call them differently? Just a suggestion. >> http://orgmode.org/cgit.cgi/org-mode.git/plain/request-assign-future.txt >> >> Also, please have a look at this page with guidance on how >> to submit a patch with a ChangeLog etc. >> >> http://orgmode.org/worg/org-contribute.html#sec-4-2 > > I did a search for such docs on orgmode.org but only found a pointer to > the list. Perhaps someone should make these links more obvious. I promoted the org-contribute.html page in the homepage of Org, thanks for bringing this up! -- Bastien