Re: [PATCH] Add a flat clocktable formatter useful for tables whose CSV export can be imported into accounting/invoiving tools such as Zoho Invoicing.

[Bastien <bzg@gnu.org>]

Hi Ross,

Ross Patterson <me@rpatterson.net> writes:

> Bastien <bzg@gnu.org> writes:
>
>> thanks for the patch.  Do you mind filling the copyright
>> assignment so we can accept the patch ?
>
> I already have an FSF Emacs Assignment from 2008-12-22, RT 393650.  Is
> there something else I need to do?

Nope.  I didn't know you had a FSF assignment.

That said, the patch looks more like an add-on to Org for a very
specific use, so putting this code in contrib/ would be better.

Also, `org-clock-clocktable-flat-columns' defines some customizable
values that are hardcoded in `org-clocktable-write-flat'.  Either the
values should not be customizable, or the `org-clocktable-write-flat'
should call them differently?  Just a suggestion.

>>   http://orgmode.org/cgit.cgi/org-mode.git/plain/request-assign-future.txt
>>
>> Also, please have a look at this page with guidance on how
>> to submit a patch with a ChangeLog etc.
>>
>>   http://orgmode.org/worg/org-contribute.html#sec-4-2
>
> I did a search for such docs on orgmode.org but only found a pointer to
> the list.  Perhaps someone should make these links more obvious.

I promoted the org-contribute.html page in the homepage of Org,
thanks for bringing this up!

-- 
 Bastien