From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: Jumping from source block to Org block ... Date: Sat, 14 Sep 2013 09:44:25 -0600 Message-ID: <87y56zqubi.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKs3g-0007G0-ON for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 11:46:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKs3c-0003pr-5f for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 11:46:52 -0400 Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:45741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKs3b-0003pn-Uo for emacs-orgmode@gnu.org; Sat, 14 Sep 2013 11:46:48 -0400 Received: by mail-pa0-f47.google.com with SMTP id kl13so3685815pab.20 for ; Sat, 14 Sep 2013 08:46:47 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: aditya siram Cc: emacs-orgmode@gnu.org aditya siram writes: > Attached is a patch that fixes a bug with jumping from source block back to > the Org file. The problem is that the current detangling behavior does not > take the :padlline flag into account. This stopped. > > Hopefully this is helpful to others ... > -deech > Hi deech, Please see the Org-mode contribution instructions at [1]. A patch of this length would require that you fill out the FSF copyright assignment paperwork before the patch could be applied. As for the content of the patch, my only question is why do you add an optional maintain-point argument to `org-babel-tangle-jump-to-org'? Is there ever a case when you would not want to maintain the point? Of much less importance I have a couple of stylistic notes about the code which are largely unrelated to its functionality and are included to make future changes easier to read and because I'm a cranky old lisp programmer. - you should indent the code s.t. no lines are longer than 79 characters - comments which float after code (e.g., ";; end of first delimiter") should only use 1 ; character - the series of if statements (if should-be-padded... if possibly-padded... if actually-padded...) would be more legible if written as a single `cond' form. Thanks for this change. It appears to pass all tests, so after the above have been addressed I'd be very happy to apply it. Thanks for contributing, this is much appreciated! If you have the time and inclination to include a test which fails without this patch applied that would be icing on the cake. Best, Footnotes: [1] http://orgmode.org/worg/org-contribute.html -- Eric Schulte https://cs.unm.edu/~eschulte PGP: 0x614CA05D