From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Kelling Subject: Re: [PATCH] Make the point visible when jumping to the mark Date: Thu, 22 May 2014 08:40:07 -0700 Message-ID: <87y4xt4yaw.fsf@treetowl.lan> References: <874n1aq9y5.fsf@treetowl.lan> <87lhtvwakr.fsf@bzg.ath.cx> <86d2f6gpj5.fsf@somewhere.org> <87r43m87in.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WnV7e-0003rj-Sq for emacs-orgmode@gnu.org; Thu, 22 May 2014 11:41:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WnV7a-0003mX-49 for emacs-orgmode@gnu.org; Thu, 22 May 2014 11:41:34 -0400 In-Reply-To: <87r43m87in.fsf@bzg.ath.cx> (Bastien's message of "Thu, 22 May 2014 11:52:48 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Sebastien Vauban , emacs-orgmode@gnu.org Bastien writes: > Hi S=C3=A9bastien, > > Sebastien Vauban > writes: > >> Even if the goal is desirable, I thought that we may not add defadvice >> in Emacs sources. > > True that, we need to clean things up. > > The route I will take is to apply Ian patch on master and then to > move all advising code into a separate org-advice.el library in the > contrib/ directory. Any suggestion for a better name? I considered this problem when I made the patch, and originally started writing it to not use advise. The alternative I see is to create org-mode versions of these functions, and binding them with the org-mode-map to override the existing functions, like we do with other functions. I prefer advice in these cases because the advice is simple and it is easier for users customizing keybinds and extending emacs. However, compared to making it a module and thus not enabled by default, I would prefer to make org-mode versions of the functions. Having them on by default will be more helpful to more users overall. I would be happy to write the patch for this, if we agree.