From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: ob-lua.el
Date: Sat, 24 May 2014 14:25:05 +0200
Message-ID: <87y4xrxt26.fsf@bzg.ath.cx>
References: <10493aa.dd867f2eeab70f315adbc3ac0113988b@afterlogic.edis.at>
	<87mwenuife.fsf@gmail.com> <87k39q2bfw.wl%dieter@schoen.or.at>
	<87oayrpp0b.fsf@bzg.ath.cx> <871tvjzbrb.wl%dieter@schoen.or.at>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40893)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WoB0k-0000zc-TN
	for emacs-orgmode@gnu.org; Sat, 24 May 2014 08:25:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WoB0f-0001hq-GL
	for emacs-orgmode@gnu.org; Sat, 24 May 2014 08:25:14 -0400
Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:53172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WoB0f-0001gU-AC
	for emacs-orgmode@gnu.org; Sat, 24 May 2014 08:25:09 -0400
Received: by mail-we0-f171.google.com with SMTP id w62so6070987wes.30
	for <emacs-orgmode@gnu.org>; Sat, 24 May 2014 05:25:08 -0700 (PDT)
In-Reply-To: <871tvjzbrb.wl%dieter@schoen.or.at> (Dieter Schoen's message of
	"Sat, 24 May 2014 12:55:52 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Dieter Schoen <dieter@schoen.or.at>
Cc: emacs-orgmode@gnu.org, Eric Schulte <schulte.eric@gmail.com>

Hi Dieter,

Dieter Schoen <dieter@schoen.or.at> writes:

> I have my name to the copyright, but left in the name of the authors
> of ob-python.el, as I used that as a template.
> Is that ok?

Yes -- but I don't see your name anywhere in the file.

> Another change to the first version is that it's now also possible
> to do :results value and :results value pp.
> (The first version still had python wrapper code in there.)

Great!

> The Lua pretty-printer function is a home-brew, as Lua does not provide
> much in that direction out of the box, at least to my knowledge.

What ob-lua.el depends on?

You declare functions that suggests there is both lua-mode.el and
lua.el* -- I think this is a leftover from ob-pyhton.el.  Can you
double-check this?  Also, there should be a note explaining how to
install lua-mode.el, since it is not part of Emacs.

* See (defcustom org-babel-lua-mode ...

Also, there is (defvar org-src-preserve-indentation) which is not
used.

Let's do some more cleaning and then apply this to master.

Thanks!

-- 
 Bastien