From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch, ox] #+INCLUDE resolves links Date: Wed, 01 Oct 2014 22:03:39 +0200 Message-ID: <87y4sz7e1w.fsf@nicolasgoaziou.fr> References: <87k34x6bjd.fsf@gmx.us> <87lhpdurfh.fsf@gmx.us> <87bnq984hd.fsf@nicolasgoaziou.fr> <87bnq5zzp7.fsf@gmx.us> <87oau4ems5.fsf@nicolasgoaziou.fr> <87d2af1qyv.fsf@gmx.us> <87tx3po7kj.fsf@nicolasgoaziou.fr> <87mw9hcsy9.fsf@gmx.us> <87zjdh89ll.fsf@nicolasgoaziou.fr> <871tqskce9.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZQ77-0007UT-E7 for emacs-orgmode@gnu.org; Wed, 01 Oct 2014 16:03:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZQ6z-0004Q4-C7 for emacs-orgmode@gnu.org; Wed, 01 Oct 2014 16:03:05 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:44059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZQ6z-0004Pv-1h for emacs-orgmode@gnu.org; Wed, 01 Oct 2014 16:02:57 -0400 In-Reply-To: <871tqskce9.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 30 Sep 2014 23:48:46 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Hello, Rasmus writes: > Changes are one sentence in the documentations, casing, and I changed > the regexp so that :only-contents is valid (it's nil). Thank you. It isn't very important, but you forgot full stops at the end of comments in the test file. > Is it better now? I think so. > I want to discuss one more important potential issue before having the > patch applied. Currently, location is ignored if the included part is > not an env (line 3381) and not a block (3392). I'm not sure this is > right. I could do one of the following: > > 1. Nothing (current state) > 2. Throw an error if location and env or block are combined. > 3. Try to use location even if block is set. Recall, though, that > location is resolved using org-mode. > 4. Let location be a general regexp if env or block is non-nil. > But then we are breaking with the org file-link idea. > 5. Make location work for org files when env or block, otherwise > throw an error. > > WDYT? I think option 1 is perfect. If a block with org contents is needed, one can always do #+begin_center #+include: "file.org::*headline" #+end_center Block and environments are really meant for literal insertion, where locations do not apply. > Less important. Should the right term) prompt for a location, or change the cursor position to > after the filename? The "right term" is structure template. Since those are configurable, I think the default, simple, behaviour is preferable. > + (only-contents > + (and (string-match ":only-contents *?\\([^: \r\t\n]\\S-*\\)?" value) Is the shy *? necessary? Regards, -- Nicolas Goaziou