From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] org.el: org-babel-load-file loads first tangle file Date: Fri, 30 Jan 2015 10:44:42 +0100 Message-ID: <87y4okpppx.fsf@nicolasgoaziou.fr> References: <54CAAAE0.208@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH872-0006bx-Uj for emacs-orgmode@gnu.org; Fri, 30 Jan 2015 04:43:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YH86z-00059V-Or for emacs-orgmode@gnu.org; Fri, 30 Jan 2015 04:43:40 -0500 Received: from relay5-d.mail.gandi.net ([2001:4b98:c:538::197]:33705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YH86z-00059N-JC for emacs-orgmode@gnu.org; Fri, 30 Jan 2015 04:43:37 -0500 In-Reply-To: <54CAAAE0.208@gmail.com> (Sami Airaksinen's message of "Thu, 29 Jan 2015 23:49:20 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sami Airaksinen Cc: emacs-orgmode@gnu.org Hello, Sami Airaksinen writes: > I use quite sophisticated (read complicated) initialization of my emacs. > Now I finally updated my emacs and org-mode upto date and found out that > org-babel-load-file doesn't work as previously. > > I don't know if you have already noticed but if your tangled source > org-mode file has multiple target files for the tangle blocks, it loads > the file which was found last. This most often isn't the file name that > was given as input. There could be more generic solution to this, but I > though that it might be best to keep this patching simple as possible. > > This is my first patch proposal so I hope I'm doing right and adding it > as an attachment to this post It looks good, thank you. However, could you also add a comment above the modified line in order to explain the car+last call? [...] > Suggestion from a patch proposal by Sami Airaksinen The line above is not necessary since you're the author of the patch anyway. Regards, -- Nicolas Goaziou