From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Ecay Subject: Re: [PATCH 9/9] ob-calc: don't leave garbage on the stack Date: Wed, 04 Nov 2015 14:41:22 +0000 Message-ID: <87y4edvncd.fsf@gmail.com> References: <1446581747-1960-1-git-send-email-oxij@oxij.org> <1446581747-1960-10-git-send-email-oxij@oxij.org> <87fv0mvw5k.fsf@gmail.com> <87a8qum14d.fsf@yin.lan> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtzFl-0003j9-1s for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 09:41:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtzFh-0000to-SX for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 09:41:32 -0500 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:34346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtzFh-0000tk-N1 for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 09:41:29 -0500 Received: by wikq8 with SMTP id q8so93572434wik.1 for ; Wed, 04 Nov 2015 06:41:29 -0800 (PST) In-Reply-To: <87a8qum14d.fsf@yin.lan> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jan Malakhovski , emacs-orgmode@gnu.org 2015ko azaroak 4an, Jan Malakhovski-ek idatzi zuen: > > Aaron Ecay writes: > >> Are you missing a close paren at the end of the above line? > > It evaluates and works ok, so I think it's ok. Ok. Then: 1. The indentation is wrong, because (calc-pop 1) is the second argument to calc-eval. 2. The prog1 form is not needed, because it only wraps a single form (the calc-eval call). This looks wrong to me, so please double-check. -- Aaron Ecay