From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] add port switch for postgresql support in ob-sql.el Date: Sun, 22 May 2016 23:47:17 +0200 Message-ID: <87y471kboa.fsf@saiph.selenimh> References: <878tz54o29.fsf@openaether.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4bDe-0000F4-DS for emacs-orgmode@gnu.org; Sun, 22 May 2016 17:47:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4bDc-0003S5-Ak for emacs-orgmode@gnu.org; Sun, 22 May 2016 17:47:29 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:34165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4bDc-0003Qq-4V for emacs-orgmode@gnu.org; Sun, 22 May 2016 17:47:28 -0400 In-Reply-To: <878tz54o29.fsf@openaether.org> (Justin Kirby's message of "Thu, 19 May 2016 19:37:18 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Justin Kirby Cc: emacs-org Hello, Justin Kirby writes: > I added a port switch for postgresql in ob-sql.el Thank you for the patch. Some comments follow. > I have attached a simple patch to fix this and have verified it works > for me. I would have loved to add some tests, but I ran into some > problems: > > 1) I could not figure out how to get just one test file to run > 2) I was not able get make test to load the sql language in babel > > > Is there a recommended/standard way to resolve these problems with > tests? See , in particular BTEST_RE and BTEST_OB_LANGUAGES environment variables. > From 4ca513afe3725fbfbefd7ad9bf54637adfd56ea2 Mon Sep 17 00:00:00 2001 > From: Justin Kirby > Date: Wed, 18 May 2016 23:14:48 -0400 > Subject: [PATCH] add dbport parameter to postgresql dbstring First letter should be upper case. You also need to provide the name of the function being modified in the commit message, e.g. lisp/ob-sql.el (org-babel-sql-dbstring-postgresql): Add PORT argument. (org-babel-execute:sql): Apply previous change. I you haven't signed FSF papers, you also need to add TINYCHANGE at the end of the commit message. Could you send an updated patch ? Also, could you provide a short notice in ORG-NEWS (located in doc/)? Regards, -- Nicolas Goaziou