emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Charles C. Berry" <ccberry@ucsd.edu>
Cc: Charles Millar <millarc@verizon.net>,
	"emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: [PATCH} Re: inline code block problem; first attempt
Date: Thu, 09 Jun 2016 13:41:38 +0200	[thread overview]
Message-ID: <87y46efv2l.fsf@saiph.selenimh> (raw)
In-Reply-To: <alpine.OSX.2.20.1606081938180.1799@charles-berrys-macbook.local> (Charles C. Berry's message of "Wed, 8 Jun 2016 19:43:26 -0700")

Hello,

"Charles C. Berry" <ccberry@ucsd.edu> writes:

> Patch atteched.
>
> Replaced ']' with '{' in the regex `header' group.
>
> Comments?

Thank you for the patch. This is better than what we have now. However,
I don't think this is the way to go.

Forbidding "{" is already a minor annoyance, but porting the same logic
to `org-element-inline-babel-call-parser', which suffers from the same
bug, means forbidding "(" ; this is a major one.

I'd rather do the same as the body part and allow "[" (and "{"
obviously), as long as they are paired. This is less restrictive, IMO,
even acceptable in the case of "(".

I also started a fix along those lines yesterday but didn't get time to
finish it yet.

WDYT?

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2016-06-09 11:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <f70128ed2c794b438fd330d1ca7b0369@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
2016-06-08 18:36 ` inline code block problem; first attempt Eric S Fraga
2016-06-08 19:47   ` Charles Millar
2016-06-08 19:56   ` Charles C. Berry
2016-06-09  2:43     ` [PATCH} " Charles C. Berry
2016-06-09 11:41       ` Nicolas Goaziou [this message]
2016-06-09 16:04         ` Charles C. Berry
2016-06-10 21:49           ` Nicolas Goaziou
2016-06-11 11:54             ` Charles Millar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y46efv2l.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=ccberry@ucsd.edu \
    --cc=emacs-orgmode@gnu.org \
    --cc=millarc@verizon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).