From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: links-9.0 v3
Date: Mon, 18 Jul 2016 14:02:20 +0200
Message-ID: <87y44zf92r.fsf@saiph.selenimh>
References: <m2lh1eesm8.fsf@Johns-MacBook-Air.local>
	<87oa6afmeu.fsf@saiph.selenimh>
	<m2vb0iky97.fsf@Johns-MacBook-Air.local>
	<87k2gxg8qm.fsf@saiph.selenimh>
	<m2shvllgt4.fsf@Johns-MacBook-Air.local>
	<8737nlfqdv.fsf@saiph.selenimh>
	<m2oa69l0ec.fsf@Johns-MacBook-Air.local>
	<87y45bvm12.fsf@saiph.selenimh>
	<m27fcvosam.fsf@Johns-MacBook-Air.local>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36264)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bP7Fj-0001Je-IO
	for emacs-orgmode@gnu.org; Mon, 18 Jul 2016 08:02:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bP7Fe-0004VH-Hq
	for emacs-orgmode@gnu.org; Mon, 18 Jul 2016 08:02:26 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:60436)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1bP7Fe-0004VD-Bj
	for emacs-orgmode@gnu.org; Mon, 18 Jul 2016 08:02:22 -0400
In-Reply-To: <m27fcvosam.fsf@Johns-MacBook-Air.local> (John Kitchin's message
	of "Sat, 09 Jul 2016 09:27:29 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: John Kitchin <jkitchin@andrew.cmu.edu>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>

John Kitchin <jkitchin@andrew.cmu.edu> writes:

> What do you think of this approach:
>
>  (defcustom org-link-parameters
> -  '(("file"  :complete 'org-file-complete-link)
> -    ("file+emacs" :follow (lambda (path) (org-open-file path '(4))))
> -    ("file+sys" :follow (lambda (path) (org-open-file path 'system)))
> +  '(("file"  :complete #'org-file-complete-link)
> +    ("file+emacs" :follow (lambda (path) (org-open-file-link path '(4))))
> +    ("file+sys" :follow (lambda (path) (org-open-file-link path 'system)))

It could work, but I suggest to rename it `org--open-file-link' or some
such, i.e., make it an internal function, because it could be confusing
with `org-open-link-from-string'.

>      ("http") ("https") ("ftp") ("mailto")
>      ("news") ("shell") ("elisp")
>      ("doi") ("message") ("help"))
> @@ -10732,6 +10732,30 @@ they must return nil.")
>  
>  (defvar org-link-search-inhibit-query nil) ;; dynamically scoped
>  (defvar clean-buffer-list-kill-buffer-names) ; Defined in midnight.el
> +
> +(defun org-open-file-link (path app)
> +  "Open PATH using APP.
> +
> +PATH is from a file link, and can have the following

missing "syntax"?

> +     [[file:~/code/main.c::255]]
> +     [[file:~/xx.org::My Target]]
> +     [[file:~/xx.org::*My Target]]
> +     [[file:~/xx.org::#my-custom-id]]
> +     [[file:~/xx.org::/regexp/]]
> +
> +APP is '(4) to open the PATH in Emacs, or 'system to use a system application."
> +  (let* ((fields (split-string path "::"))	   
> +	 (option (when (cdr fields)
> +		   (mapconcat 'identity (cdr fields) ""))))

(and (cdr field)
     (mapconcat #'identity (cdr fields) ""))
     
> +    (apply #'org-open-file
> +	   (car fields)
> +	   app
> +	   (cond ((not option) nil)
> +		 ((org-string-match-p "\\`[0-9]+\\'" option)

org-string-match-p -> string-match-p


Regards,