From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Fix clocktable scope parameter
Date: Sun, 05 Mar 2017 11:54:59 +0100
Message-ID: <87y3wk6lj0.fsf@nicolasgoaziou.fr>
References: <8760ml2q30.fsf@gmail.com> <87y3zh5iu0.fsf@nicolasgoaziou.fr>
	<87eg19uqji.fsf@gmail.com> <m2oa0dnk62.fsf@tsdye.com>
	<87d1gtuhou.fsf@gmail.com> <87h9646hdk.fsf@nicolasgoaziou.fr>
	<87h964kbo4.fsf@gmail.com> <87h9634m01.fsf@nicolasgoaziou.fr>
	<87zijvzev0.fsf@gmail.com> <87zijv31dz.fsf@nicolasgoaziou.fr>
	<87zih04s3n.fsf@brickabode.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33496)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ckToe-0002f9-4a
	for emacs-orgmode@gnu.org; Sun, 05 Mar 2017 05:55:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ckTod-0001na-Hn
	for emacs-orgmode@gnu.org; Sun, 05 Mar 2017 05:55:04 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:37829)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1ckTod-0001nU-BR
	for emacs-orgmode@gnu.org; Sun, 05 Mar 2017 05:55:03 -0500
In-Reply-To: <87zih04s3n.fsf@brickabode.com> (Eduardo Bellani's message of
	"Sat, 04 Mar 2017 19:03:40 -0300")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Eduardo Bellani <ebellani@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>

Hello,


Thank you. Some comments follow.

Eduardo Bellani <ebellani@gmail.com> writes:

> org-clock.el: Fix clocktable scope parameter

Why is it a "fix"? I think this patch belongs to master branch, not
maint.

> * lisp/org-clock.el (org-dblock-write:clocktable): Funcall the scope
>   argument if it is a function.
>
> * doc/org.texi: Document the feature of using a function, both bounded
>   and as a lambda form, as the scope for the clocktable.

Since a bounded symbol and a lambda form are both functions, I'd rather
not distinguish them. Actually, this distinction is usually not made.
> +             symbol     @r{scan the files returned by calling the nullary function bound to this symbol}
> +             lambda-form  @r{Same as above, but the nullary function is passed as a lambda form.}

See above. I suggest:

  function @r{...}

> -		    ((pred consp) scope)
> +                    ((pred #'functionp) (funcall scope))

  (pred functionp)

> +                    ((pred listp) scope)

Is there any reason to change consp into listp? This change doesn't
appear in the commit message.


Could you provide an entry in ORG-NEWS? Also, would you mind writing
a couple of simple tests in test-org-clock.el?

Regards,

-- 
Nicolas Goaziou