From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Prevent auto-fill-mode from filling Property values in drawers
Date: Sun, 04 Feb 2018 23:16:47 +0100
Message-ID: <87y3k8h034.fsf@nicolasgoaziou.fr>
References: <CAFyQvY3W0Kfpo=46iAC52g4XVh2HFurV0SzpehZgU249-Z7xhA@mail.gmail.com>
	<CAFyQvY3sOe-2t8dQhOb9xtB1mOEAmDSuig+8D+-0uX=p5RF0rA@mail.gmail.com>
	<87shaiuoxe.fsf@nicolasgoaziou.fr>
	<CAFyQvY30UvYG3qcbmDVB5GXzCO8DhvDqMKYfe8cK26yVquAt2w@mail.gmail.com>
	<87d11muofz.fsf@nicolasgoaziou.fr>
	<CAFyQvY30iFiogaqGDqOxfEA57xSn1VDGh6BZyu=xCg2GfFAGbg@mail.gmail.com>
	<87372i82p5.fsf@alphaville.usersys.redhat.com>
	<CAFyQvY2du0B+aTY=tauy=WZSNR=jmt35gfJmWXu7qnJ1_nAS1Q@mail.gmail.com>
	<874lmxvhwb.fsf@nicolasgoaziou.fr>
	<CAFyQvY2b5MMB_osbBVdstzrX6eFiysJL1KAA4V8MBK7TRJw=-A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43678)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1eiSan-0002Kq-Hq
	for emacs-orgmode@gnu.org; Sun, 04 Feb 2018 17:16:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1eiSag-0005i6-Dm
	for emacs-orgmode@gnu.org; Sun, 04 Feb 2018 17:16:56 -0500
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:36381)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1eiSag-0005f4-6D
	for emacs-orgmode@gnu.org; Sun, 04 Feb 2018 17:16:50 -0500
In-Reply-To: <CAFyQvY2b5MMB_osbBVdstzrX6eFiysJL1KAA4V8MBK7TRJw=-A@mail.gmail.com>
	(Kaushal Modi's message of "Sun, 04 Feb 2018 15:52:36 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: Nick Dokos <ndokos@gmail.com>, emacs-orgmode@gnu.org

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Of course. But "the right thing" would be to prevent call to auto filling
> within `org-return` (somehow? I haven't yet dug deeper into that) if point
> is in a property drawer.

`org-return' doesn't call any auto fill function.

> If you want to add a new property, use C-c C-x p, or, if you insist on
>> typing it manually, use C-q <RET> instead.
>>
>
> C-c C-x p is a bit unnatural and also longer to type than RET,

Yet, it doesn't break properties drawers.

> especially
> if the point is already inside the property drawer. Yes, if my point is
> inside the subtree, and I think of adding a property, C-c C-x p is great!
>
> C-q  RET is a good tip, but again, RET would be better.

Actually, that would be C-q C-j, not C-q <RET>

> I'll try hacking something around this, tweaking org-return should work
> using a simple advice. Would a patch be welcome for this?

I don't think tweaking `org-return' is a good solution. This is not the
only way to break a line (e.g. "C-q C-j", or "C-M-o"), so it would not
be a panacea.

You may want to use fill-nobreak-predicate variable instead, e.g. with
`org-at-property-p'.