From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: buffer-file-name in [* Org src *] buffers
Date: Wed, 14 Mar 2018 20:57:53 +0100 [thread overview]
Message-ID: <87y3iujupq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <a064d3f0-139a-d434-7fb3-e23dfbcf4a6e@gmail.com> ("Clément Pit-Claudel"'s message of "Wed, 14 Mar 2018 10:18:55 -0400")
Hello,
Clément Pit-Claudel <cpitclaudel@gmail.com> writes:
> 1. Set buffer-offer-save to 'always; this guarantees that C-x s will ask about the edit buffer.
> 2. Add an entry to kill-buffer-query-functions. For example, with-editor (used by magit) does this:
> (add-hook 'kill-buffer-query-functions
> 'with-editor-kill-buffer-noop nil t)
>
> With these, we could leave buffer-file-name to nil.
>
> WDYT?
`buffer-offer-save' is already set to a non-nil value. See
`org-src-mode-configure-edit-buffer'.
> PS: point (1) shares an issue with the original implementation (it
> always prompts during save-some-buffers). One fix to this could be to
> add a buffer-modification-hook that marks the source buffer as modified
> when the edit buffer is modified, and to make change the source buffer's
> write-contents-functions to offer to save edit buffers too.
Right. Then we might as well use the second solution instead, and leave
out both `buffer-file-name' and `buffer-offer-save'.
So, would you want to implement it?
Regards,
--
Nicolas Goaziou 0x80A93738
next prev parent reply other threads:[~2018-03-14 19:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 22:56 buffer-file-name in [* Org src *] buffers Clément Pit-Claudel
2018-03-12 3:47 ` numbchild
2018-03-12 14:38 ` Nicolas Goaziou
2018-03-14 14:18 ` Clément Pit-Claudel
2018-03-14 19:57 ` Nicolas Goaziou [this message]
2018-04-26 23:34 ` Bastien
2018-04-27 5:06 ` Clément Pit-Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3iujupq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=cpitclaudel@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).