From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 4/4] ob-clojure.el: Add ClojureScript tangle language
 extension
Date: Mon, 23 Apr 2018 11:28:21 +0200
Message-ID: <87y3he5l1m.fsf@nicolasgoaziou.fr>
References: <20180422205003.87836-1-roberthambrock@gmail.com>
	<20180422205003.87836-5-roberthambrock@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36807)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1fAXlv-00021Z-8A
	for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 05:28:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1fAXlp-0006Ey-OP
	for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 05:28:31 -0400
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47127)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1fAXlp-0006ES-HU
	for emacs-orgmode@gnu.org; Mon, 23 Apr 2018 05:28:25 -0400
In-Reply-To: <20180422205003.87836-5-roberthambrock@gmail.com>
	(roberthambrock@gmail.com's message of "Sun, 22 Apr 2018 22:50:03
	+0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: roberthambrock@gmail.com
Cc: emacs-orgmode@gnu.org

Hello,

roberthambrock@gmail.com writes:

> * lisp/ob-clojure.el (org-babel-tangle-langs-exts): Add ClojureScript
> to the supported language extensions.

Thank you. Some comments follow.

>  (defvar org-babel-tangle-lang-exts)
>  (add-to-list 'org-babel-tangle-lang-exts '("clojure" . "clj"))
> +(add-to-list 'org-babel-tangle-lang-exts '("clojurescript" . "cljs"))
>  
>  (defvar org-babel-default-header-args:clojure '())
>  (defvar org-babel-header-args:clojure '((package . :any)))

Don't you need to also define
`org-babel-default-header-args:clojurescript' and
`org-babel-header-args:clojurescript' ?

Also, this entails a comment at the beginning of the library, IMO.

Regards,

-- 
Nicolas Goaziou