From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header
 argument
Date: Thu, 14 Mar 2019 15:58:15 +0100
Message-ID: <87y35hv6yg.fsf@nicolasgoaziou.fr>
References: <87sgvpg3bq.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:40780)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1h4RoN-00005K-Eo
	for emacs-orgmode@gnu.org; Thu, 14 Mar 2019 10:58:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1h4RoM-0001jV-37
	for emacs-orgmode@gnu.org; Thu, 14 Mar 2019 10:58:23 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:59687)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1h4RoL-0001ij-P2
	for emacs-orgmode@gnu.org; Thu, 14 Mar 2019 10:58:22 -0400
In-Reply-To: <87sgvpg3bq.fsf@gmail.com> (Sebastian Miele's message of "Thu, 14
	Mar 2019 10:25:45 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Sebastian Miele <sebastian.miele@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Sebastian Miele <sebastian.miele@gmail.com> writes:

> * testing/lisp/test-ob-emacs-lisp.el
>   (test-ob-emacs-lisp-dynamic-lexical-text,
>   test-ob-emacs-lisp-dynamic-lexical-expr,
>   ob-emacs-lisp/dynamic-lexical-execute,
>   ob-emacs-lisp/dynamic-lexical-edit): Add tests that check the
>   correct handling of the :lexical header argument when executing
>   source blocks and when creating editing buffers for source blocks.

Thank you.

<nitpick>
However, your tests are very convoluted. It is better than no test, but
if, unfortunately, one of them fail in some distant future, it may take
more time understanding what happens in the test than actually fixing
the bug.

Would you mind rewriting them with simple macros like, e.g.,
`org-test-with-temp-text', and use as little helper functions as
possible? IMO, code repetition in tests is not a problem.
</nitpick>

Regards,

-- 
Nicolas Goaziou