From: Sebastian Miele <sebastian.miele@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument
Date: Thu, 14 Mar 2019 19:28:47 +0000 [thread overview]
Message-ID: <87y35hs1ao.fsf@gmail.com> (raw)
In-Reply-To: <87y35hv6yg.fsf@nicolasgoaziou.fr>
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> [...]
>
> <nitpick>
> However, your tests are very convoluted. It is better than no test, but
> if, unfortunately, one of them fail in some distant future, it may take
> more time understanding what happens in the test than actually fixing
> the bug.
>
> Would you mind rewriting them with simple macros like, e.g.,
> `org-test-with-temp-text', and use as little helper functions as
> possible? IMO, code repetition in tests is not a problem.
> </nitpick>
After some initial tooth-grinding, I did rewrite them, and actually like
the result more than the previous version. Thank you for the suggestion!
Here is the updated patch:
* testing/lisp/test-ob-emacs-lisp.el
(ob-emacs-lisp/dynamic-lexical-execute,
ob-emacs-lisp/dynamic-lexical-edit): Add tests that check the
correct handling of the :lexical header argument when executing
source blocks and when creating editing buffers for source blocks.
---
testing/lisp/test-ob-emacs-lisp.el | 89 ++++++++++++++++++++++++++++++
1 file changed, 89 insertions(+)
diff --git a/testing/lisp/test-ob-emacs-lisp.el b/testing/lisp/test-ob-emacs-lisp.el
index 078cad988..24a373f86 100644
--- a/testing/lisp/test-ob-emacs-lisp.el
+++ b/testing/lisp/test-ob-emacs-lisp.el
@@ -76,6 +76,95 @@
(buffer-substring-no-properties (line-beginning-position 2)
(line-end-position 2))))))
+(ert-deftest ob-emacs-lisp/dynamic-lexical-execute ()
+ (cl-flet ((execute (text)
+ (org-test-with-temp-text-in-file text
+ (org-babel-next-src-block)
+ (org-babel-execute-maybe)
+ (re-search-forward "results" nil t)
+ (re-search-forward ": " nil t)
+ (buffer-substring-no-properties (point) (point-at-eol)))))
+
+ (should (string= "dynamic" (execute "
+#+begin_src emacs-lisp :lexical no :results verbatim
+(let ((x 'dynamic)) (funcall (let ((x 'lexical)) (lambda () x))))
+#+end_src")))
+
+ (should (string= "lexical" (execute "
+#+begin_src emacs-lisp :lexical yes :results verbatim
+(let ((x 'dynamic)) (funcall (let ((x 'lexical)) (lambda () x))))
+#+end_src")))
+
+ (should (string= "dynamic" (let ((x 'dynamic)) (execute "
+#+begin_src emacs-lisp :lexical no :results verbatim
+x
+#+end_src"))))
+
+ (should (string= "lexical" (let ((x 'dynamic)) (execute "
+#+begin_src emacs-lisp :lexical '((x . lexical)) :results verbatim
+x
+#+end_src"))))
+
+ ;; Src block execution uses `eval'. As of 2019-02-26, `eval' does
+ ;; not dynamically bind `lexical-binding' to the value of its
+ ;; LEXICAL parameter. Hence, (eval 'lexical-binding LEXICAL)
+ ;; evaluates to the same value that just `lexical-binding'
+ ;; evaluates to, even if LEXICAL is different. So tests like the
+ ;; following do not work here:
+ ;;
+ ;; (should (string= "t" (execute "
+ ;; #+begin_src emacs-lisp :lexical yes :results verbatim
+ ;; lexical-binding
+ ;; #+end_src")))
+ ;;
+ ;; However, the corresponding test in
+ ;; `ob-emacs-lisp/dynamic-lexical-edit' does work.
+ ))
+
+(ert-deftest ob-emacs-lisp/dynamic-lexical-edit ()
+ (cl-flet ((execute (text)
+ (org-test-with-temp-text-in-file text
+ (org-babel-next-src-block)
+ (org-edit-src-code)
+ (goto-char (point-max))
+ (prog1 (eval-last-sexp 0)
+ (org-edit-src-exit)))))
+
+ (should (eq 'dynamic (execute "
+#+begin_src emacs-lisp :lexical no :results verbatim
+(let ((x 'dynamic)) (funcall (let ((x 'lexical)) (lambda () x))))
+#+end_src")))
+
+ (should (eq 'lexical (execute "
+#+begin_src emacs-lisp :lexical yes :results verbatim
+(let ((x 'dynamic)) (funcall (let ((x 'lexical)) (lambda () x))))
+#+end_src")))
+
+ (should (eq 'dynamic (let ((x 'dynamic)) (execute "
+#+begin_src emacs-lisp :lexical no :results verbatim
+x
+#+end_src"))))
+
+ (should (eq 'lexical (let ((x 'dynamic)) (execute "
+#+begin_src emacs-lisp :lexical '((x . lexical)) :results verbatim
+x
+#+end_src"))))
+
+ (should (equal nil (execute "
+#+begin_src emacs-lisp :lexical no :results verbatim
+lexical-binding
+#+end_src")))
+
+ (should (equal t (execute "
+#+begin_src emacs-lisp :lexical yes :results verbatim
+lexical-binding
+#+end_src")))
+
+ (should (equal '((x . 0)) (execute "
+#+begin_src emacs-lisp :lexical '((x . 0)) :results verbatim
+lexical-binding
+#+end_src")))))
+
(provide 'test-ob-emacs-lisp)
;;; test-ob-emacs-lisp.el ends here
--
2.21.0
next prev parent reply other threads:[~2019-03-14 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 10:25 [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument Sebastian Miele
2019-03-14 14:58 ` Nicolas Goaziou
2019-03-14 19:28 ` Sebastian Miele [this message]
2019-03-14 22:38 ` Nicolas Goaziou
2019-03-15 19:28 ` Sebastian Miele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y35hs1ao.fsf@gmail.com \
--to=sebastian.miele@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).